Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2088.outbound.protection.outlook.com [40.107.223.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D12578F4F for ; Mon, 6 Jan 2025 17:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.88 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736183969; cv=fail; b=NdX9L0db6inISxHVI1EnAewmSno/q+VFlENrcxkHYDr+shn/KoVZE1hZRqIYzD3NMwgSr5a+Su90GjPWh5kvxhnyzOovVDPOCzqm2dAy0tUYbupCMnfT1WgdtJ9L6QRrMmmbWraQGserGuz3SK6FTs5l2VK0h/05Tlb5NSdKax4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736183969; c=relaxed/simple; bh=OU0budqVZmXys+98d8FL/Z/ha245TWgMwLJsXYhlZeA=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=hyVPTF8LZqJpO49sl/7HgeW3/CgEDxT/fsNeo2TfuM8aFJpPTnqbxtzTKFhLywO/Ko/Xeb0BPMbrGJKFPrenmYg8VepayvnHQiiJ7s7Dl7oQnoKNqU57uPwrUaKawj0A7t6LmLiuwBL6EE+3v7g334J4ExWakAN1kbQi+i8xo/0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=LLyyH4Gu; arc=fail smtp.client-ip=40.107.223.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="LLyyH4Gu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UM83weKH8IHPVQF/cJM923Q1+sX4u1iyaCr2H3up570wa7AEfwOZe8Q2NKtRcMUkBqXycvF2iPKyMEjpyAbKIvRyYbvK9KZiarX+cw3WaVl/g3ne5zX5rSVbjbIWKEW9QdegcLOioLnE5HLIoMIwRxF4uc0GJMtoPNg8qO9po9qb/4x3/H1YdkN/qdEaF7gj8iaRg4XxbO5zBapMuYG2HpoCx8gLwPAPlN1okRs9g+5kfU6e4wTAz6aMvgPCSzGq2AAd9HqNvm7oef3g8Xht+9yZ3RkIcmPUhHMWDIXuYYBnGgvmLm+3ZpWTtF3i5mtskoWCA2pRSYgZzbGG2myMfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EeO2W3Me4FY4xxu4oDpAk8CSmFm5F9R3RB0LLQIPb1s=; b=d6BQlk3g8DQqAogVZWQgSI8bzyNKtoMwWADnl7ejslUxdWWHW/EIACe1HkaaA3tRofWxF8Zstm+HAGd/dPLDJQGfW+rYjLr2UkSdAb4TNH0wpNgqP3QXgrBkwZnHW/GgvytrktGN5c2pyo5+IA4JHdxVje7q0S/MCxFAIg3DMu0B9gxIlwl0QiWqlbswdyhWbaCjk15ObJU+L99Z36yUw/DjOWZFQj6sUf8eTiaOtLZESrnfIddxv+T16nikhhpPLxXHqSmEkGsJ0/HxMTeDKs5n/IsYY5HFYvtXDhiYbrWhgFBxd62WB0/fVwvMwHeC4/lrHjCmwQlsAwbQzZ2S+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EeO2W3Me4FY4xxu4oDpAk8CSmFm5F9R3RB0LLQIPb1s=; b=LLyyH4GuGUlKB+bJei3Bo6LkdwulR1pfU4lLebV92CvHk8y0yuN4NzM2pN4xMg8gCJSr0QQQVnyd0YxUUFuPT5eCDdGVOV1aSflOaTy9kxc0pAgwlNWS49U1vN59qlOP6DDMO+D+naZH+Bt4CnrdCapHGhEwaq1WIduy7G9lelY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH0PR12MB7982.namprd12.prod.outlook.com (2603:10b6:510:28d::5) by IA1PR12MB9030.namprd12.prod.outlook.com (2603:10b6:208:3f2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.17; Mon, 6 Jan 2025 17:19:21 +0000 Received: from PH0PR12MB7982.namprd12.prod.outlook.com ([fe80::bfd5:ffcf:f153:636a]) by PH0PR12MB7982.namprd12.prod.outlook.com ([fe80::bfd5:ffcf:f153:636a%6]) with mapi id 15.20.8314.015; Mon, 6 Jan 2025 17:19:21 +0000 Message-ID: <8dd77269-62f7-4fa9-be09-c36f59e63f60@amd.com> Date: Mon, 6 Jan 2025 09:19:25 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] pds_core: limit loop over fw name list To: Shannon Nelson , netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, jacob.e.keller@intel.com Cc: brett.creeley@amd.com References: <20250103195147.7408-1-shannon.nelson@amd.com> Content-Language: en-US From: Brett Creeley In-Reply-To: <20250103195147.7408-1-shannon.nelson@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR13CA0034.namprd13.prod.outlook.com (2603:10b6:a03:2c2::9) To PH0PR12MB7982.namprd12.prod.outlook.com (2603:10b6:510:28d::5) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR12MB7982:EE_|IA1PR12MB9030:EE_ X-MS-Office365-Filtering-Correlation-Id: a389337b-c69b-4a7a-8548-08dd2e76429f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RzBDNmZQUFRJdnNwQ0daK2h4NVJJODlhU2xWYk9PTUpnZlRmTTdKTnErVkhC?= =?utf-8?B?VUV4TzgwVVNoWCtpMFBaSlozSzQrODBRUGRubE5VbUIzTG1yblFJeldsRlBR?= =?utf-8?B?RzZWcXlrZktiNDhmVDNMbmkveFhXM01nL1NQZ00yTGRURGRlNTh1MndGdU9I?= =?utf-8?B?enZpaWdpRitLR1ZFOEFMb0xNZ2RPeExndEpnanprQUVxanRHZm82VmdjU3Rz?= =?utf-8?B?bnpHRmh5SkhObUlXelR1SnlLNnplY3V0UVhnSHovMmVzQjRYei9EZnc2L0Ev?= =?utf-8?B?SU5hanYvdnVMbTdRVFVVMW95SFMxRjhJRFRKckFzeE1hTHdhaTMxK0E5Nm11?= =?utf-8?B?MWl2ZHphZFRwdzRxWlFlM3IzanhQa1MvaklxZGhLMUpVNnhTMHdEbExiakN4?= =?utf-8?B?elFWeHFKNEV0WEhieWZwMXcrT20yOS9JNi9ERU1qUGwrb0ZEaEFLd0UrVWJk?= =?utf-8?B?cFFoNEpuUFRHcVNKS1A0cmo2UVRMSldCa21iU3doVnhJK3NSMmE0MDRZZDZ0?= =?utf-8?B?RUY3RnBkbEtSSVlBQjk0V1hwMGxZYm5Dd1cwVlk3cUYzY096OXRrZU16bjNR?= =?utf-8?B?ZlNJSmdLVnJEUERoRytiMUJMSWJUQlBBUmVtVS9Xc0Mxd3YvQTJ4MEhLU1J0?= =?utf-8?B?dlpQQ3pvUDNHYmVlV2Rpdi9pSjJyNGZka2ZtTjdXMzFFdVVwTnpUdDJUbkN0?= =?utf-8?B?UWtXSTdxUHdYSWM4TDhQNmFtUFBxbFNOdDhqYlRPQmJ6RVI2YXZ4UVFtVmN4?= =?utf-8?B?dmVJc0VCSkxiVlFiSnVqN2NxZDZ5UFJIWklWU08rYWZ1U3ZvcnpqaG5Hamwz?= =?utf-8?B?cXpmWXIxR3pqKzhDRTV1TDg4aVZYSVFnVm40QmppM2RzaEs0ZkNxZ2cwQ2cy?= =?utf-8?B?NVNCNGo2QzNaakt0VGkwZnpLaVJLL0RQZUtTZ2RaenpoNXpVYkFpQmVWSXpB?= =?utf-8?B?dklPbTBFOThNbmdybkNUdFdyV2ptTlIrRTY1VGJvS01qSjRFNjFTVmlCeGlr?= =?utf-8?B?blVFUElwRG5pUndkTGwycUxjZWZWNzYrWDB3Tkd4c0tyS3RxOENzVm5DRTdP?= =?utf-8?B?NXh1MWhQRFF0QmRPNXZnYksrZ1JRejRWMnVEV2lFZ2tTR1NidVA2K2JtRTZW?= =?utf-8?B?WmZTZ3llaDFlZGEwRFhYYWtLdVNZUGJ0WGR6SVhidGNFN2Y4ZjVyMGxhbGpr?= =?utf-8?B?bzBWRmRldmJDeWZKNDg3MUxhTk5MN2l4aWczSEc5ZG5CWXNlSG16VVpVbG96?= =?utf-8?B?VjhqcGN2N0Z4bk1XbWx2eVdqNXBpUmQyQXZTckk2SmpsVGFNQjhabjVhZTIw?= =?utf-8?B?T09uNERMbHF6eWFGZ1BPZHRyVEozeGhWZklhWlZaUlZaZnhZNUpJN2pvdG1G?= =?utf-8?B?R2Qyc0xQSjlwSFBFMUVkb0RRc09PL0ZlQVNKd01LVnRxQmt1N1F4THNBamZI?= =?utf-8?B?Sm1qclJ0MzJybXd4dk1rai9tMDI0YU1ONGk2VE1mcG51c1ZDUXR4QVdGdlhF?= =?utf-8?B?YmVaU25tSlVQc1l1VlB3T2laNEdiMmQ5TndVMFAxd2NOKzlVeHNBMDJhQ3Ar?= =?utf-8?B?T0lEeDR6Zm1lSWt6cHFUWHN4KzNLRWx6enNyVHExdHcvcmxldHhtY1VUN2hv?= =?utf-8?B?NWIwZWNjcnM4UkZWZ05pTTB3YkUwam1JWTJlUEtiS2F3M2pFSHM0Zk0wdGh3?= =?utf-8?B?aXRNZjFLSGFzUEFZYzZYZmlXL3dOcDdPUyt6V3dDcGg4R1N4WGh1RGJpdXpw?= =?utf-8?B?U2hKVHRyWUFhcWU4VXFpUkVlR2NkT2ZaVTZBbm81RVZYb1JKQldYQWFyV202?= =?utf-8?B?YkNHeEkvZXdtSCtQNXR0VlR1TlVXaXJnSnRYc1BUUzdNKzRHbkticzJ2SDJ2?= =?utf-8?Q?GSyh73Q/wUJVE?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR12MB7982.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGo2WWdUOVpjaHozampNM0J2dmRZNFVyVFpZTm1wTTNVbHFLbG95MjRvWXBU?= =?utf-8?B?NWl2QXNrV0E5c01xT1VkanpvQ1pOdDk0Q3EzS2NiU1V1REY5eVhuc1NiZEhT?= =?utf-8?B?Uk5pMWgwcUE2WGoxcm5IUyt4ekJrallJcXR5ZmkzVXRNQ0lYVFBuRC9UVXUw?= =?utf-8?B?UUhMM1V3R1ZzeHZNQ3BGU3d0b3RrYlRwMHN2VkhhTFVxQ21hZ2RxOEJSaG9u?= =?utf-8?B?UEwyYkEvdUdLYnZYUGxGM010ajZsRksxSkpBZG1VMllYSVh2dXlqUEZGZmkw?= =?utf-8?B?QmJ4Sm5mUmZkb2N6MXViaEkwVEdHdnpCVDFZY1gyVURPMlc4S05PMlRRb0Vs?= =?utf-8?B?YzFhejZwaHRKUjZlR1N0cGg1RElDdUp5VW5tVURXcjJMUGdkM1cvUU50OHhH?= =?utf-8?B?SWJKWmxEYnVLTXhpNUpXWTYycjd0Y1NVY1ZZQjErSkQwbnZyK3ZodXV1NTlS?= =?utf-8?B?SmdmblUxNUN2dGk5Q1MyUDBLMGFnVVZTMzU1Rkc4U2FWUXA4b3JRZTdvMVM1?= =?utf-8?B?aW8wSFd0S015YzM5NzliMUIwL0N1MHl2cGIxTFUzQVdHSWowMHBIdUZhY0Fn?= =?utf-8?B?TG10SGxWSll2SHBUd21Ma0xjSVlOZnZrREpibkU5MlZNUlB1RWJRWFc5Z2Uz?= =?utf-8?B?K0JLVDNhcFIvUDFHQjNlVElad3pKanFiWS9DZmRrdG1TQVZ5MEJIN2tqYmRQ?= =?utf-8?B?czhwUzc4T0NCQ3VVZFlzcmErYWl0d2R2T1RXbnNnelRjcFUyNit4c25wbWtl?= =?utf-8?B?YXhpLytvcFpEQzVwYVIyK0dHRk92eGUwQ0xpM0s2UVozbmlTaThwclRxa21J?= =?utf-8?B?cWRjazBmazJiazRqdUhLbXpvajVtWE9OcnBUTTgzK05JWGtqZ0xtV3NTRHVz?= =?utf-8?B?aElUYWJ1YlJDdzVCc2Q4QVJNK3RSM1Zzcm9LZytweU5ZTFY2NGxPVVRHUmlp?= =?utf-8?B?VjRsZHJkQUUzMFRaeGFZREVZL3Zva2MwcjlxL2VBM042Y1Z5YnFtRlE2VlNl?= =?utf-8?B?MU4rUWpWRnVqdTVTSnBYNVoxaGhVRXV1ZWpHNjBpb0pXaW93bkNpWDRCKzM2?= =?utf-8?B?WFZxWGhCV2Q3eEJYb29oM2VtSGZiTGR1KzJrWnUrOGhvbWVoNE5uK243Y01P?= =?utf-8?B?MXVKWEk0emJZb1YwekhVeDFhRm1yeW80RCtoRmZndnRacVFMQ1J2b1Z1QlpP?= =?utf-8?B?emltZ2xHdElRMTRBeDd6UlFOcHVTNnNOUDRvMUV3a3Q0ZnhtazFwTG5EU25Q?= =?utf-8?B?dFN0ci9ORzhINjk5SzRMNUxwa0ZmNHB2YkVKVmo2d3ljTzBqemlLVGI2S2hH?= =?utf-8?B?eDZSTyt1aWNEemE3eDdhNjF3WnJ4bThxRTdPMTU0TkFTb0lwQ2k0cW95eGha?= =?utf-8?B?UVVXbDlaMGFydTEyUzQ3RjI4VVM0QWF4ZENSMVF1TFdPV3RuSmZLMnk0b0xm?= =?utf-8?B?aE1sS255OEVVaUlMSkNweU50dkxjam9OS2QrOXEvYTZmMERDV2E1c0VPc1JT?= =?utf-8?B?K3lpVmxCbGJTUGpHVWV3MG5Jd2NIU3dzT093Z042K2t0WFVNQ1UwbUdYQjcr?= =?utf-8?B?OFFkUHpCdkRpbVpPOEtLVEI4eUtibUwzVE13U3lBUklteHVsOUt3SHR5TFht?= =?utf-8?B?WUY4SFREcFhoMHZxUGpSRzVUL2JDYjA0ZkNmOGYvN0laSzljVmlidFowbUxl?= =?utf-8?B?VWIxOFBFRlJEU01NblgwcWZOdkhLZVphL3UxVE5QZ1d0VWJOaWZRUmEwWGE4?= =?utf-8?B?bnMwS0ZiaU5mZ2RNM0VnNlI4Z1VmdGI2ZU13Zk5INlBNdWxlcXJ4Z3NZZWR1?= =?utf-8?B?N3dob2JVdFkxTzRsalo1T29ndTh3NysvenhZNTlRWloyK2VXTXBlRmpRYnB5?= =?utf-8?B?QTl5bHIybW9pMkViSzhadUVaQk1lWjM0RSt6Um9WVTlKalZLZkh5ZlRDOGlR?= =?utf-8?B?VGM4Q2J6WmoyS0xHUXRXbjJPaThzSHdNVHVwK2g2Zks4dC9OME9vL2o0cEhS?= =?utf-8?B?a0ZvUVJTUnJ4QUVKalJ1cDc5VjVhdUNnOVpnaGNBRzJvVkdNNktVSmlzYjNX?= =?utf-8?B?Q3RNVGkrT1NiRWd5M0ZtWHdYR2NZdUpubTd1cTlIVlYzSVRJSHBJQ0JDaVJn?= =?utf-8?Q?jHdZtCnQC754C9TVEL5kVhGDX?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a389337b-c69b-4a7a-8548-08dd2e76429f X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB7982.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2025 17:19:21.6798 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SsgsV2pewDONIna1JscrBeicF4VzK7jmCM7dd5mxDRgT55jXTohkfJgYxkIPyvItIYGAsX30+HGmfgEYgTzuGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB9030 On 1/3/2025 11:51 AM, Shannon Nelson wrote: > Add an array size limit to the for-loop to be sure we don't try > to reference a fw_version string off the end of the fw info names > array. We know that our firmware only has a limited number > of firmware slot names, but we shouldn't leave this unchecked. > > Fixes: 45d76f492938 ("pds_core: set up device and adminq") > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/amd/pds_core/devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c > index 2681889162a2..44971e71991f 100644 > --- a/drivers/net/ethernet/amd/pds_core/devlink.c > +++ b/drivers/net/ethernet/amd/pds_core/devlink.c > @@ -118,7 +118,7 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req, > if (err && err != -EIO) > return err; > > - listlen = fw_list.num_fw_slots; > + listlen = min(fw_list.num_fw_slots, ARRAY_SIZE(fw_list.fw_names)); LGTM. Thanks! Reviewed-by: Brett Creeley > for (i = 0; i < listlen; i++) { > if (i < ARRAY_SIZE(fw_slotnames)) > strscpy(buf, fw_slotnames[i], sizeof(buf));