From: "ordex (Code Review)" Date: Sat, 25 Jan 2025 23:46:54 +0000 In-Reply-To: References: Reply-To: a@...2181..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <8e3e05618e145deac5a0f93ad9b2a0487425803e-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="b8yIgRDjhGs="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: man: extend --persist-tun section List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --b8yIgRDjhGs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, ordex, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/819?usp=3Demail to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by flichtenheld Change subject: man: extend --persist-tun section ...................................................................... man: extend --persist-tun section The current persist-tun section has no mention of retaining IP/routes and its potential usage in traffic leaking protection. Spell this out to allow the user to better understand when this option can play an important role. Change-Id: I6816f61b308ca9f6d1f9f687a6dc8e0aa2d044e0 Signed-off-by: Antonio Quartulli --- M doc/man-sections/vpn-network-options.rst 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/19/819/2 diff --git a/doc/man-sections/vpn-network-options.rst b/doc/man-sections/vp= n-network-options.rst index fc76939..67f7e1f 100644 --- a/doc/man-sections/vpn-network-options.rst +++ b/doc/man-sections/vpn-network-options.rst @@ -312,6 +312,15 @@ :code:`SIGUSR1` is a restart signal similar to :code:`SIGHUP`, but which offers finer-grained control over reset options. + On Linux, this option can be useful when OpenVPN is not executed as + root and the CAP_NET_ADMIN has not been granted, because the process + would otherwise not be allowed to bring the interface down and back up. + + Alongside the above, using ``--persist-tun`` allows the tunnel interface + to retain all IP/route settings, thus allowing the user to implement + any advanced traffic leaking protection (please note that for full + protection, extra route/firewall rules must be in place). + --redirect-gateway flags Automatically execute routing commands to cause all outgoing IP traffic to be redirected over the VPN. This is a client-side option. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/819?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6816f61b308ca9f6d1f9f687a6dc8e0aa2d044e0 Gerrit-Change-Number: 819 Gerrit-PatchSet: 2 Gerrit-Owner: ordex Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-MessageType: newpatchset --b8yIgRDjhGs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, ordex, plaisthos. <= /p>

ordex uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Code-Review-1 by flichtenheld

man: extend --persist-tun section

The = current persist-tun section has no mention of
retaining IP/routes and it= s potential usage in traffic
leaking protection.

Spell this out t= o allow the user to better understand
when this option can play an impor= tant role.

Change-Id: I6816f61b308ca9f6d1f9f687a6dc8e0aa2d044e0
S= igned-off-by: Antonio Quartulli <antonio@...2726...>
---
M doc/= man-sections/vpn-network-options.rst
1 file changed, 9 insertions(+), 0 = deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs=
/changes/19/819/2
diff --git a/doc/man-sections/vpn-network-options=
.rst b/doc/man-sections/vpn-network-options.rst
index fc769= 39..67f7e1f 100644
--- a/doc/man-sections/vpn-network-optio= ns.rst
+++ b/doc/man-sections/vpn-network-options.rst
@@ -312,6 +312,15 @@
:code:`SIGUSR1` is a res= tart signal similar to :code:`SIGHUP`, but which
offers = finer-grained control over reset options.

+ On Linux, this option can be usef= ul when OpenVPN is not executed as

+ root and the CAP_NET_ADMIN has not been granted, because t= he process
+ would o= therwise not be allowed to bring the interface down and back up.
= +
+ Alongside the above, using ``--persist-tun`` al= lows the tunnel interface
+ to retain all IP/route settings, thus allowing the user to implemen= t
+ any advanced tra= ffic leaking protection (please note that for full
+ protection, extra route/firewall rules mus= t be in place).
+
--redirect-gateway flags
Automatically exe= cute routing commands to cause all outgoing IP traffic
t= o be redirected over the VPN. This is a client-side option.

To view, visit change 819. To unsubscribe, or for help writ= ing mail filters, visit sett= ings.

<= link itemprop=3D"url" href=3D"http://gerrit.openvpn.net/c/openvpn/+/819?usp= =3Demail"/>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6816f61b308ca9f6d1f9f687a6d= c8e0aa2d044e0
Gerrit-Change-Number: 819
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <a@...2181...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-MessageType: newpatchset
--b8yIgRDjhGs=--