Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FCE5C433EF for ; Wed, 5 Jan 2022 12:55:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BE43382F91; Wed, 5 Jan 2022 13:55:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FxKLLrgy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 56DF782F91; Wed, 5 Jan 2022 13:55:06 +0100 (CET) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9433D82F91 for ; Wed, 5 Jan 2022 13:55:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.bossman075@gmail.com Received: by mail-qk1-x72c.google.com with SMTP id t66so26648466qkb.4 for ; Wed, 05 Jan 2022 04:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=YvhZvEjB9MJcXEwXuwz7D2X13815SwgrstsqJ7R7fuA=; b=FxKLLrgyt+aB1z8pQRI10NBr6VJdLgmdraZZC0cUKGbrtzoxE4ffBa0++fF3jGmNWL /7Qua2fFDEeLwJn+nT5RxsF7u+FLv7+8aXdQlhMBvFV6+s33u1StebztuiIV7JkXGlYZ Vx8Y1lNlRD7d3p7jiueO5VQWhDmehXADwUvccZ1UOtpOkSXXpMjxx/mZb5g56DdwF0My fQbKmkpTmafY/hwGmwHl/bqIDVaSrqmCyMbC+6mqKxEc9QP/WCcYuPo3od+cfGelAiqM OOZAyhEAcZvi0CVbWbtbTpQJCi/ENPDFOrDxrMFpTjU6UBrl8d42MQ+i4+yRF0/xG8qN kKYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YvhZvEjB9MJcXEwXuwz7D2X13815SwgrstsqJ7R7fuA=; b=tvEXWioiIBMUvlHnzQEHDaAIm1bDRUB+NY9oMSVWvuWEr71QrV8UZLlySrQsOcgeVL yzERfnNT2/F9tfl1HiS9Ta1UYXBH/ecqiMUR9lkeKu1fWs5eEKIo0WIOPK2MzFVYRgpg eFnIggbYYSF7JqvREZPfHglrNNlQOeT6rage8MDGSr4DObxyxOQKWz/ShMXXzpvBEyxO 7XC9h4xJzI3lmO+0PNftkyvVFLZv/+l+iL8lAL/qUZkO3hRl7pFtiNiUS2JflC//OTWV ses8BwPcEeyXr1to8TjcYM56o/+hpKZ/hwmcygIh8J7gaCD7rneD0nEgkORhy1ez2fK2 OvFg== X-Gm-Message-State: AOAM531pmz9jrwxDz93KRi0wXVC0IrrpNr15fzmcmcG29BGkwY6vwxRh SEynQ1NQgkO/TG+FzNT/1z0= X-Google-Smtp-Source: ABdhPJxxsdc1djE50nX2ZiPKz+3n9/f20xxB3Lpn73uRDMOE2w4mLg5fLzOVXRZGGSmsTKTqYqqUmQ== X-Received: by 2002:a05:620a:6d3:: with SMTP id 19mr38495364qky.781.1641387300095; Wed, 05 Jan 2022 04:55:00 -0800 (PST) Received: from [10.4.10.38] (146-115-144-188.s4282.c3-0.nwt-cbr1.sbo-nwt.ma.cable.rcncustomer.com. [146.115.144.188]) by smtp.gmail.com with ESMTPSA id v10sm36895865qtk.13.2022.01.05.04.54.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jan 2022 04:54:59 -0800 (PST) Message-ID: <8e85b8ea-d400-c3c1-4610-c88f5ed0510c@gmail.com> Date: Wed, 5 Jan 2022 07:54:57 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 00/11] Add support for SUNIV and F1C100s. Content-Language: en-US To: Andre Przywara , Icenowy Zheng Cc: u-boot@lists.denx.de, jagan@amarulasolutions.com, hdegoede@redhat.com, sjg@chromium.org, marek.behun@nic.cz, festevam@denx.de, narmstrong@baylibre.com, tharvey@gateworks.com, christianshewitt@gmail.com, pbrobinson@gmail.com, lokeshvutla@ti.com, jernej.skrabec@gmail.com, hs@denx.de, samuel@sholland.org, arnaud.ferraris@gmail.com, giulio.benetti@benettiengineering.com, thirtythreeforty@gmail.com References: <20220105003508.1143140-1-Mr.Bossman075@gmail.com> <16f1b5aed8b616547084c64d2ec4398446681392.camel@aosc.io> <20220105121415.2df58be3@slackpad.fritz.box> From: Jesse Taube In-Reply-To: <20220105121415.2df58be3@slackpad.fritz.box> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/5/22 07:14, Andre Przywara wrote: > On Wed, 05 Jan 2022 19:36:29 +0800 > Icenowy Zheng wrote: > > Hi Jesse, > >> 在 2022-01-04星期二的 19:34 -0500,Jesse Taube写道: >>> This patch set aims to add suport for the SUNIV and F1C100s. >>> Suport has been in linux for a while now, but not in u-boot. >>> >>> This patchset contains: >>> - CPU specific initialization code >>> - SUNIV dram driver >>> - SUNIV clock driver adaption >>> - SUNIV gpio driver adaption >>> - SUNIV uart driver adaption >>> - F1C100s basic support >>> >>> I am hoping to get Icenowy's patches in as it seems she hasnt >>> submitted >>> in a while. The only edits I made to her code is rebasing it against >>> ML >>> and changing some formating. I also re-grouped her commits. >> >> I got too lazy to send it (because I think F1C100s is just too weak)... >> >>> >>> I am wondering if the dram driver should be moved into device drivers >>> rather than in mach-sunxi. >>> I am also wondering if it is okay to submit some one elses code, >>> and if so how should I do so. >> >> As you are keeping my SoB and adding yours, it's totally okay. > > Thanks Icenowy for confirming! > > Jesse: yes, it's perfectly fine to send patches from someone else, as > long as you keep the authorship, their SoB, and add your's. > Typical reasons are lack of time or interest from the original author. > > But it's customary to ask the author first I did but it must have gotten lost in the cosmos. , and care should be taken > when changing patches, as this might not be in the interest of the > original author (and they are the ones who will get blamed for bugs). > Also please mark the series either as a Resend or as a v2. > > So with Icenowy's confirmation above I consider this fine. > > But what was actually holding back this series was lack of review, > testing and/or interest. Well the price of the SOC has gained it some popularity, aswell as a couple forum posts. > Similar to Icenowy my personal interest in > crufty old cores is somewhat limited, so this wasn't very high on my > priority list. It is very slow but its a good challenge. > > So given that there is apparently some interest now: > Can you confirm that you have reviewed the series, or at least tested > this? I have tested this yes. I would be interested to know if a second pair of eyes had a > look, and to what extent. I'm Sending giulio.benetti@ some boards I made he will also test. I'm sure many other people will be willing to test aswell. > I don't have any hardware, so would need to > rely on others to make sure this code is somewhat sane. I can send you one of my many boards :) > And it basically looks like a v2 of Icenowy's series, so can you give a > Changelog of the differences? I skimmed over her original series back > then, so I would be interested in what makes this version special. It passes checkpatch on the latest. > > Cheers, > Andre > >> Thanks for cleaning up these patches! ;-) NP! I took https://github.com/Lichee-Pi/u-boot/tree/nano-v2018.01 re-based it against mainline and fixed formatting in a few files. I also removed the spi-flash driver as it was causing issues and we can boot from sdcard for now. there are some things I did to make the old code compatible with new code but mostly preprocessor and configs. For the dram driver I had to change a bit but none of the logic, i am worried that i may have to move it to /drivers. Do you want a more comprehensive list of changes?