Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05E4CC25B75 for ; Wed, 15 May 2024 09:10:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 723D888233; Wed, 15 May 2024 11:10:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1715764217; bh=X757Um8BCAzc3PreBMDUqHBhuhnPj/DBlEA7r3PvS6E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=paGV+YGrUI4tcQ8lTvH7LYGpgTnLFd9LvN73g3GQzl/eYtV3ahF2xmoD3c+Jkq0L3 3WciQxIWrePx+W7dWXuqPm82EYkfRizIeq9hveSALkMRIy5eRm4os5Td5rvREhu0rU RakSfsmWi0LqNNx3VBmIXZRrWdSZt8dUyS5BX1BKG3rxKdJQsJq4qNA8hKbUSduC1c t1IHf6ClgShMlritlt45zjCwMujTDnA815K0yswO5uzbngxlx+iUeAab/BLUUTL74A 0q0dSk5PX+YYn4K6tvKPcLY+6h1Rsrdc++kl8D3GROUJ7QbA/BSRy1i8jB+sWXoEcZ NbWQcuSba9NyA== Received: by phobos.denx.de (Postfix, from userid 109) id 6FC9F88216; Wed, 15 May 2024 11:10:16 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [80.241.59.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9809C88233 for ; Wed, 15 May 2024 11:10:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4VfS9Z3crfz9tZd; Wed, 15 May 2024 11:10:10 +0200 (CEST) Message-ID: <8ea997c2-e164-4ea1-9a75-28bbf159827b@denx.de> Date: Wed, 15 May 2024 11:10:09 +0200 MIME-Version: 1.0 Subject: Re: [PATCH u-boot-mvebu 10/10] arm: mvebu: turris_omnia: Support old DDR3 training, selectable via env var Content-Language: en-US To: =?UTF-8?Q?Marek_Beh=C3=BAn?= Cc: u-boot@lists.denx.de References: <20240415163043.7482-1-kabel@kernel.org> <20240415163043.7482-11-kabel@kernel.org> <149e251a-baa7-4512-990a-d332d0d6177f@denx.de> <20240515105906.3cfca4fb@dellmb> From: Stefan Roese In-Reply-To: <20240515105906.3cfca4fb@dellmb> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4VfS9Z3crfz9tZd X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Marek, On 5/15/24 10:59, Marek Behún wrote: > On Mon, 6 May 2024 12:03:55 +0200 > Stefan Roese wrote: > >> Hi Marek, >> >> On 4/15/24 18:30, Marek Behún wrote: >>> Support old DDR3 training code on Turris Omnia, selectable by U-Boot >>> enviroment variable. >>> >>> Users experiencing DDR3 initialization failures or random crashes of the >>> operating system due to incorrect DDR3 configuration can select the old >>> DDR3 training implementation to fix those issues by setting the >>> environment variable >>> env set omnia_ddr3_training old >>> env save >>> >>> Signed-off-by: Marek Behún >>> --- >>> arch/arm/mach-mvebu/Kconfig | 1 + >>> board/CZ.NIC/turris_omnia/Makefile | 1 + >>> board/CZ.NIC/turris_omnia/old_ddr3_training.c | 79 +++++++++++++++++++ >>> board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +- >>> 4 files changed, 82 insertions(+), 1 deletion(-) >>> create mode 100644 board/CZ.NIC/turris_omnia/old_ddr3_training.c >> >> For turris_omnia_defconfig, this is dropped when compiled: >> >> drivers/ddr/marvell/a38x/old/ddr3_debug.c:776:12: warning: >> 'ddr3_tip_access_atr' declared 'static' but never defined >> [-Wunused-function] >> 776 | static int ddr3_tip_access_atr(u32 dev_num, u32 flag_id, u32 >> value, u32 **ptr); >> | ^~~~~~~~~~~~~~~~~~~ > > And it also seems that there is still something wrong with this > old DDR training code port. Some boards still experience random bugs > with this, but not with the U-Boot from 2015. :-( Hmmm, strange. How to continue? Are these "old DDR training patches" on hold for now? Thanks, Stefan