From: "plaisthos (Code Review)"
Date: Tue, 28 Nov 2023 13:39:57 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID: <8ec89e4f6dacadb48b3be39c6c63b5a8dce605f7-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="XNJCIwpqpSY="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Check PRF
availability on initialisation and add --force-tls-key-mate...
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , openvpn-devel
--XNJCIwpqpSY=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/460?usp=3Demail )
Change subject: Check PRF availability on initialisation and add --force-tl=
s-key-material-export
......................................................................
Patch Set 1:
(2 comments)
File src/openvpn/crypto.c:
http://gerrit.openvpn.net/c/openvpn/+/460/comment/cbdb8303_d315f0e5 :
PS1, Line 1797: * limits our compatibility to other 2.6.x+ OpernVPN pe=
ers. Do a simple
> "OpenVPN"
Done
File src/openvpn/options.c:
http://gerrit.openvpn.net/c/openvpn/+/460/comment/ba9c2025_db846721 :
PS1, Line 2583: if (options->force_key_material_export)
> This is in "if (options->mode =3D=3D MODE_SERVER)" which is wrong.
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee6ca89c7e86c70
Gerrit-Change-Number: 460
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Tue, 28 Nov 2023 13:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--XNJCIwpqpSY=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
View C=
hange
2 comments:
Done
File src/openvpn/options.c:
To view, visit change 460. =
To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee=
6ca89c7e86c70
Gerrit-Change-Number: 460
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Tue, 28 Nov 2023 13:39:57=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--XNJCIwpqpSY=--