From: "flichtenheld (Code Review)" Date: Mon, 20 Nov 2023 11:55:56 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <8f5e47aa3d3ce87a5567f7f965ad46ea16601d05-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="U/GvYIS5+ds="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Allow the TLS session to send out TLS alerts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --U/GvYIS5+ds= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/449?usp=3Demail ) Change subject: Allow the TLS session to send out TLS alerts ...................................................................... Patch Set 1: Code-Review-2 (9 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/449/comment/ce9fb57d_f01b1b19 : PS1, Line 20: Sending out alerts is a slight compromise in security as ale= rts give superfluous space http://gerrit.openvpn.net/c/openvpn/+/449/comment/8bf6026e_889913be : PS1, Line 22: out. But since all other consumers TLS implementation are alr= eady doing this "consumer TLS implementations" http://gerrit.openvpn.net/c/openvpn/+/449/comment/a80886c0_b6d5627c : PS1, Line 23: and TLS implementation (nowadays) are very careful not to lea= k (sensitive) "implementations" Patchset: PS1: Can't judge the state machine patch really. But the doubts about the shutdo= wn function makes this a NAK either way. File Changes.rst: http://gerrit.openvpn.net/c/openvpn/+/449/comment/9c3faa2e_d4fd7ba3 : PS1, Line 6: OpenVPN 2.7 will send out TLS alerts to peer informing the= m if the TLS "peers" http://gerrit.openvpn.net/c/openvpn/+/449/comment/fd295cc6_2def6a9b : PS1, Line 10: a timeout when the server just stop responding completely. "stops" File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/449/comment/38284760_a524bebe : PS1, Line 2846: * Shut down an SSL session, so an SSL close notify is sent= if there no other "there is" http://gerrit.openvpn.net/c/openvpn/+/449/comment/8e4b3e48_338f6a18 : PS1, Line 2851: do_ssl_shutdown(struct key_state *ks) Why do we need an empty function? Was this supposed to call key_state_ssl_s= hutdown? File src/openvpn/ssl_backend.h: http://gerrit.openvpn.net/c/openvpn/+/449/comment/fa6d4de4_e2eda72e : PS1, Line 376: * a shutdown altert. alert -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/449?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0ad48915004ddee587e97c8ed190ba8ee989e48d Gerrit-Change-Number: 449 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Mon, 20 Nov 2023 11:55:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --U/GvYIS5+ds= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 1:Code-Review -2=

Vi= ew Change

9 comments:

  • Commit Message:

    • Patch Set #1, Line 20: Sending out alerts is a slight co= mpromise in security as alerts give

      superfluous space

    • Patch Set = #1, Line 22: out. But s= ince all other consumers TLS implementation are already doing this

      "consumer= TLS implementations"

    • Patch Set #1, Line 23: and TLS implementation (nowaday= s) are very careful not to leak (sensitive)

      "implementations"

    • <= /ul>
    • Patchset:

      • Patch Set #1:

        Can't judge the state machine patch = really. But the doubts about the shutdown function makes this a NAK either = way.

    • File Changes= .rst:

    • Fi= le src/openvpn/ssl.c:

      • Patch Set #1, Line 2846: * Shut down an SSL session, so an SSL close notify is sent if there n= o other

        Patch Set #1, Line 2851: do_ssl_shutdown(struct key_state = *ks)

        W= hy do we need an empty function? Was this supposed to call key_state_ssl_sh= utdown?

    • File src/= openvpn/ssl_backend.h:

      • <= a href=3D"http://gerrit.openvpn.net/c/openvpn/+/449/comment/fa6d4de4_e2eda7= 2e">Patch Set #1, Line 376: * a shutdown altert.

        alert

    To view, visit change 449. = To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I0ad48915004ddee587e97c8ed19= 0ba8ee989e48d
    Gerrit-Change-Number: 449
    Gerrit-PatchSet: 1
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Comment-Date: Mon, 20 Nov 2023 11:55:56= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --U/GvYIS5+ds=--