From: Tvrtko Ursulin Subject: Re: [PATCH 3/3] drm/i915/guc: general tidying up (submission) Date: Thu, 15 Sep 2016 09:57:18 +0100 Message-ID: <8fad03af-c76c-f012-e0a6-cc306a712a11@linux.intel.com> References: <1473711577-11454-1-git-send-email-david.s.gordon@intel.com> <1473711577-11454-4-git-send-email-david.s.gordon@intel.com> <88875836-d9e4-72b2-9875-8da444d1fee8@linux.intel.com> <35472b67-9044-a772-88e5-18eb7d9b6468@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 218FE6E036 for ; Thu, 15 Sep 2016 08:57:21 +0000 (UTC) In-Reply-To: <35472b67-9044-a772-88e5-18eb7d9b6468@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE0LzA5LzIwMTYgMTg6MDAsIERhdmUgR29yZG9uIHdyb3RlOgo+IE9uIDE0LzA5LzE2IDE2 OjIyLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4KPj4gT24gMTIvMDkvMjAxNiAyMToxOSwgRGF2 ZSBHb3Jkb24gd3JvdGU6Cj4+PiBSZW5hbWluZyB0byBtb3JlIGNvbnNpc3RlbnQgc2NoZW1lLCBh bmQgdXBkYXRpbmcgY29tbWVudHMsIG1vc3RseQo+Pj4gYWJvdXQgaTkxNV9ndWNfd3FfcmVzZXJ2 ZSgpLCBha2EgaTkxNV9ndWNfd3FfY2hlY2tfc3BhY2UoKS4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5 OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDYzCj4+PiArKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Z3VjLmggICAgICAgICAgIHwgIDIgKy0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf bHJjLmMgICAgICAgICAgIHwgIDIgKy0KPj4+ICAgMyBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRp b25zKCspLCAzMyBkZWxldGlvbnMoLSkKPj4+Cj4KPiBbc25pcF0KPgo+Pj4gICBpbnQgaTkxNV9n dWNfc3VibWlzc2lvbl9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4+ ICAgewo+Pj4gKyAgICBjb25zdCBzaXplX3QgY3R4c2l6ZSA9IHNpemVvZihzdHJ1Y3QgZ3VjX2Nv bnRleHRfZGVzYyk7Cj4+PiArICAgIGNvbnN0IHNpemVfdCBwb29sc2l6ZSA9IEdVQ19NQVhfR1BV X0NPTlRFWFRTICogY3R4c2l6ZTsKPj4+ICsgICAgY29uc3Qgc2l6ZV90IGdlbXNpemUgPSByb3Vu ZF91cChwb29sc2l6ZSwgUEFHRV9TSVpFKTsKPj4+ICAgICAgIHN0cnVjdCBpbnRlbF9ndWMgKmd1 YyA9ICZkZXZfcHJpdi0+Z3VjOwo+Pj4gICAgICAgc3RydWN0IGk5MTVfdm1hICp2bWE7Cj4+PiAt ICAgIHUzMiBzaXplOwo+Pj4gICAgICAgICAvKiBXaXBlIGJpdG1hcCAmIGRlbGV0ZSBjbGllbnQg aW4gY2FzZSBvZiByZWluaXRpYWxpc2F0aW9uICovCj4+PiAgICAgICBiaXRtYXBfY2xlYXIoZ3Vj LT5kb29yYmVsbF9iaXRtYXAsIDAsIEdVQ19NQVhfRE9PUkJFTExTKTsKPj4+IEBAIC05ODUsMTUg Kzk4NywxNCBAQCBpbnQgaTkxNV9ndWNfc3VibWlzc2lvbl9pbml0KHN0cnVjdAo+Pj4gZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+PiAgICAgICBpZiAoZ3VjLT5jdHhfcG9vbF92bWEpCj4+ PiAgICAgICAgICAgcmV0dXJuIDA7IC8qIGFscmVhZHkgYWxsb2NhdGVkICovCj4+PiAgIC0gICAg c2l6ZSA9IFBBR0VfQUxJR04oR1VDX01BWF9HUFVfQ09OVEVYVFMqc2l6ZW9mKHN0cnVjdAo+Pj4g Z3VjX2NvbnRleHRfZGVzYykpOwo+Pj4gLSAgICB2bWEgPSBndWNfYWxsb2NhdGVfdm1hKGd1Yywg c2l6ZSk7Cj4+PiArICAgIHZtYSA9IGd1Y19hbGxvY2F0ZV92bWEoZ3VjLCBnZW1zaXplKTsKPj4K Pj4gUEFHRV9BTElHTiBsb3N0IC0gbG93ZXIgbGF5ZXJzIGRvIHRoYXQgZm9yIHVzPyBJIGRvbid0 IGhhdmUgZWFzeSBhY2Nlc3MKPj4gdG8gdGhlIHRyZWUgYXQgdGhlIG1vbWVudCB0byBjaGVjayBh bmQgSSBraW5kIG9mIGNhbid0IHJlbWVtYmVyIHJpZ2h0IAo+PiBub3cuCj4KPiBQQUdFX0FMSUdO IGhlcmUgaXMgcmVwbGFjZWQgYnkgdXNpbmcgcm91bmRfdXAoLi4uLCBQQUdFX1NJWkUpIGF0IHRo ZSAKPiBwb2ludCB3aGVyZSB0aGUgY29uc3RhbnQgaXMgZGVmaW5lZCBhIGZldyBsaW5lcyBhYm92 ZS4gSSB0aGluayAKPiByb3VuZF91cCgpIGlzIGNsZWFyZXIsIGJlY2F1c2UgImFsaWduIiBjb3Vs ZCBlcXVhbGx5IHdlbGwgbWVhbiByb3VuZCAKPiBkb3duLiBBbnl3YXkgImFsaWduIiAodXAgb3Ig ZG93bikgaXMgc29tZXRoaW5nIHlvdSBkbyB0byBhZGRyZXNzZXMgb3IgCj4gb2Zmc2V0cywgbm90 IHNpemVzLgoKSSBmYWlsZWQgdG8gc3BvdCB0aGF0IGxpbmUuIDooIFNob3VsZCByZWFsbHkgdGFr ZSBhIGxvbmcgaG9saWRheS4gOikKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtv LnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==