From: Chris Wilson Subject: Re: [PATCH] Disable DRI2 if we are running on shadowfb Date: Wed, 22 Sep 2010 15:42:52 +0100 Message-ID: <8u3s8d$jlcgpf@orsmga001.jf.intel.com> References: <1285156047-21138-1-git-send-email-jcristau@debian.org> <20100922133550.GA5473@melanie.nicotinebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 5552E9E7A9 for ; Wed, 22 Sep 2010 07:43:06 -0700 (PDT) In-Reply-To: <20100922133550.GA5473@melanie.nicotinebsd.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Owain Ainsworth , Julien Cristau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 22 Sep 2010 14:35:50 +0100, Owain Ainsworth wrote: > On Wed, Sep 22, 2010 at 01:47:27PM +0200, Julien Cristau wrote: > > Without this change, DRI2 gets enabled but doesn't work and glxinfo > > crashes my X server. > > I think we need a bigger hammer than this. > > The problem is that when we disable acceleration (EIO returned from > execbuffer), the same thing happens. I think a fix for this should also > deal with that case. Probably something conditional on the > force_fallback member at dri2 time... (we can disallow dri2 > connections, right?) This is what we get at the moment by returning buffers with name == 0 to the client. Just we still appear to be exercising what were rarely tested error paths... -Chris -- Chris Wilson, Intel Open Source Technology Centre