From: Chris Wilson Subject: Re: [PATCH] drm/i915: Implement fair lru eviction across both rings. (v2) Date: Fri, 06 Aug 2010 20:06:16 +0100 Message-ID: <8u3s94$g5f2mm@orsmga002.jf.intel.com> References: <89kc63@fmsmga002.fm.intel.com> <1281093945-7848-1-git-send-email-chris@chris-wilson.co.uk> <20100806185830.GA3603@viiv.ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id D8CFF9E74D for ; Fri, 6 Aug 2010 12:06:19 -0700 (PDT) In-Reply-To: <20100806185830.GA3603@viiv.ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 6 Aug 2010 20:58:30 +0200, Daniel Vetter wrote: > On Fri, Aug 06, 2010 at 12:25:45PM +0100, Chris Wilson wrote: > > + return i915_gem_evict_everything(dev); > > I think this should be equivalent to > > return -ENOMEM; Yes, we could return -ENOSPC and then do_execbuffer() would unpin and call i915_gem_evict_everything() before retrying. I'm happy for anybody to paint it a completely different colour just as soon as it is heading upstream. :) -- Chris Wilson, Intel Open Source Technology Centre