From: Chris Wilson Subject: Re: [PATCH 4/4] drm/i915: add new param to force audio on or off for HDMI/DP port Date: Sun, 19 Sep 2010 09:57:47 +0100 Message-ID: <8u3s94$gi67h8@orsmga002.jf.intel.com> References: <1284879129-19720-1-git-send-email-zhenyuw@linux.intel.com> <1284879129-19720-5-git-send-email-zhenyuw@linux.intel.com> <89k83a$9n3khs@azsmga001.ch.intel.com> <20100919082206.GL15857@zhen-devel.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100919082206.GL15857@zhen-devel.sh.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Zhenyu Wang Cc: intel-gfx@lists.freedesktop.org, fengguang.wu@intel.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sun, 19 Sep 2010 16:22:06 +0800, Zhenyu Wang wrote: > On 2010.09.19 09:14:53 +0100, Chris Wilson wrote: > > On Sun, 19 Sep 2010 14:52:09 +0800, Zhenyu Wang wrote: > > > Two reasons to add this param, one is for some AV device requiring > > > HDMI input for audio, but some device might not have sane EDID info > > > to enable audio on HDMI port. Another is for testing purpose. > > > > I was thinking along the lines of a connector property for force_audio. > > oh, right, that's much better. sorry, I forgot about it completely. ;) No worries, I've written up a couple of patches to add the connector properties on top of your series. So just a couple of minor tweaks and getting Adam's seal of approval for the core changes and I'll apply the series to next. Thanks! -Chris -- Chris Wilson, Intel Open Source Technology Centre