From: Jon Hunter Subject: Re: [PATCH] dmaengine: tegra210-adma: fix pm_runtime_get_sync failure Date: Thu, 4 Jun 2020 18:45:11 +0100 Message-ID: <900909fe-fa15-fbca-80f7-79aeee721ed9@nvidia.com> References: <20200603184104.4475-1-navid.emamdoost@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200603184104.4475-1-navid.emamdoost-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Navid Emamdoost , Laxman Dewangan , Vinod Koul , Dan Williams , Thierry Reding , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: emamd001-OJFnDUYgAso@public.gmane.org, wu000273-OJFnDUYgAso@public.gmane.org, kjlu-OJFnDUYgAso@public.gmane.org, smccaman-OJFnDUYgAso@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 03/06/2020 19:41, Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost > --- > drivers/dma/tegra210-adma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c > index c4ce5dfb149b..e8c749cd3fe8 100644 > --- a/drivers/dma/tegra210-adma.c > +++ b/drivers/dma/tegra210-adma.c > @@ -659,6 +659,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) > ret = pm_runtime_get_sync(tdc2dev(tdc)); > if (ret < 0) { > free_irq(tdc->irq, tdc); > + pm_runtime_put(tdc2dev(tdc)); > return ret; > } Please do not send two patches with the same $subject that are fixing two different areas of the driver. In fact, please squash these two patches into a single fix and resend because they are fixing the same issue. Jon -- nvpublic