Received: from [140.186.70.92] (port=44396 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvyGz-0003He-Aj for qemu-devel@nongnu.org; Wed, 15 Sep 2010 16:08:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvyGy-0002lD-7O for qemu-devel@nongnu.org; Wed, 15 Sep 2010 16:08:05 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:50476) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvyGx-0002l0-UA for qemu-devel@nongnu.org; Wed, 15 Sep 2010 16:08:04 -0400 Message-Id: <907FA2CE-7EE2-45DC-99AA-B2FC53DF839D@web.de> From: =?ISO-8859-1?Q?Andreas_F=E4rber?= In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Apple Message framework v936) Date: Wed, 15 Sep 2010 22:07:40 +0200 References: <1284574159-892-1-git-send-email-andreas.faerber@web.de> <15F942FE-97D7-4747-A80E-219FF54DDB04@web.de> Sender: andreas.faerber@web.de Subject: [Qemu-devel] Re: [PATCH v6] Introduce qemu_madvise() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Andrea Arcangeli , qemu-devel@nongnu.org, Alexander Graf Am 15.09.2010 um 21:50 schrieb Blue Swirl: > On Wed, Sep 15, 2010 at 7:35 PM, Andreas F=E4rber = > wrote: >> Maybe return -1 and set errno to the posix_madvise() return code? =20 >> (but is it >> errno =3D -retval or errno =3D retval then?) > > An advantage of posix_madvise() semantics is that no mucking with > errno is needed. Though existing code should be checked if they rely > on madvise() semantics instead. perror() after the MADV_DONTFORK failure does, right? Andreas=