From: "mattock (Code Review)" Date: Tue, 20 May 2025 11:51:11 +0000 In-Reply-To: References: Reply-To: sasepp@...2783..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <909b4eeeddb290505ac9fbd3771ca68d12b36ff9-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="YE4PvFodzbM="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: t_server_null: print error when server startup fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , plaisthos , openvpn-devel --YE4PvFodzbM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/o= penvpn/+/1024?usp=3Demail ) Change subject: t_server_null: print error when server startup fails ...................................................................... Patch Set 1: (1 comment) File tests/t_server_null_server.sh: http://gerrit.openvpn.net/c/openvpn/+/1024/comment/864a35bd_87c44e01 : PS1, Line 27: # we run OpenVPN without --daemon and --log to catch the = underlying error. > This doesn't explain why we can't use the log file from the failed startu= p? Please elaborate. I can't remember the impact of --log, so I need to test again. I vaguely re= call nothing ever going to the logs if the startup fails. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1024?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I39dc6b08952a06dae7901e468f9487c8541d83c3 Gerrit-Change-Number: 1024 Gerrit-PatchSet: 1 Gerrit-Owner: mattock Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 20 May 2025 11:51:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --YE4PvFodzbM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View = Change

1 comment:

    =
  • File tests/t_server_null_server.sh:=

    • Patch Set #1, Lin= e 27: # we run Open= VPN without --daemon and --log to catch the underlying error.

      =

      This doesn't explain why we can't use the log file from th= e failed startup? Please elaborate.

      I can't remember the impact of --lo= g, so I need to test again. I vaguely recall nothing ever going to the logs= if the startup fails.

To view, visit change 1024. To= unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I39dc6b08952a06dae7901e468f9= 487c8541d83c3
Gerrit-Change-Number: 1024
Gerrit-PatchSet: 1
Gerrit-Owner: mattock <sasepp@...2783...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 20 May 2025 11:51:11= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--YE4PvFodzbM=--