Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B0CFECAAD1 for ; Sat, 27 Aug 2022 04:03:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0D3FC8420E; Sat, 27 Aug 2022 06:03:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 9127384409; Sat, 27 Aug 2022 06:03:06 +0200 (CEST) Received: from mail-m11876.qiye.163.com (mail-m11876.qiye.163.com [115.236.118.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DF53E8403D for ; Sat, 27 Aug 2022 06:03:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11876.qiye.163.com (Hmail) with ESMTPA id 6495A3C019A; Sat, 27 Aug 2022 12:02:49 +0800 (CST) Message-ID: <90a309d3-447e-2008-6bb1-e8d88bd2d3a7@rock-chips.com> Date: Sat, 27 Aug 2022 12:02:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 2/4] rockchip: rk-3399: rock-pi-4: dts: Add XTX SPI NOR 4MiB Flash chip in Rock Pi 4 boards from rev 1.4 on. Content-Language: en-US To: Xavier Drudis Ferran , u-boot@lists.denx.de Cc: Simon Glass , Philipp Tomsich References: <20220720153610.GD2049@begut> <20220720154142.GF2049@begut> From: Kever Yang In-Reply-To: <20220720154142.GF2049@begut> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJSktLSjdXWS1ZQUlXWQ8JGhUIEh9ZQVlDQhlNVk8eS0lNSEsdGhhJTFUTARMWGhIXJB QOD1lXWRgSC1lBWU5DVUlJVUxVSkpPWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVSktLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PD46CRw4Vj0wEQE1MS0#Vj1R HTxPCUhVSlVKTU1KTkxJQk1CQ0lNVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFNSk9NNwY+ X-HM-Tid: 0a82dd7774262eb2kusn6495a3c019a X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2022/7/20 23:41, Xavier Drudis Ferran wrote: > Configure Rock Pi 4 to boot from SPI NOR Flash. > > Based on flash chip, board documentation and tests, this is the > fastest I could use it. > > This seems to be the minimum necessary configuration for Rock Pi 4 to > be able to boot from SPI NOR Flash. > > With the next patch, it works to sf probe 1:0, sf read, sf erase, sf > write, sf read and then boot linux and flashrom can write to > it. Sometimes flashrom seems to fail to write when at U-Boot stage > there was no sf read or write, not sure why. Might work better after > a little while off power. > > Note: It seems to work with or without CONFIG_SPL_SPI_FLASH_TINY If I > disable it, and enable CONFIG_SPL_SPI_FLASH_SFDP_SUPPORT I have > to increase CONFIG_SPL_MAX_SIZE (I set it to 0x2e800) because > the SPL grew over 1200 bytes bigger. It might work better, or > just be chance, but it boots from SPI 0.3s slower. So I leave > this out of this patch. > > Changed since v2: > > - added CONFIG_SPL_DM_SEQ_ALIAS to keep spi1 numeration consistent > between SPL and U-Boot > > Changed since v1: > > - include CONFIG_SF_DEFAULT_BUS=1 now that numeration > will be unified between U-Boot and SPL (at patch 5/5) > > Cc: Simon Glass > Cc: Philipp Tomsich > Cc: Kever Yang > > Signed-off-by: Xavier Drudis Ferran Reviewed-by: Kever Yang Thanks, - Kever > --- > arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 18 ++++++++++++++++++ > configs/rock-pi-4-rk3399_defconfig | 22 ++++++++++++++++++++++ > 2 files changed, 40 insertions(+) > > diff --git a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi > index c17e769f64..4c2fe8f6bc 100644 > --- a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi > +++ b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi > @@ -15,3 +15,21 @@ > &vdd_log { > regulator-init-microvolt = <950000>; > }; > + > +&spi1 { > + status = "okay"; > + spi-max-frequency = <40000000>; > + spi-activate-delay = <12000>; /* 12 ms */ > + > + norflash: flash@0 { > + compatible = "rockchip,spidev", "jedec,spi-nor"; > + reg = <0>; > + > + spi-max-frequency = <40000000>; > + spi-cpha; > + spi-cpol; > + > + status = "okay"; > + u-boot,dm-pre-reloc; > + }; > +}; > diff --git a/configs/rock-pi-4-rk3399_defconfig b/configs/rock-pi-4-rk3399_defconfig > index cf2e9fbde3..d5fadcb64f 100644 > --- a/configs/rock-pi-4-rk3399_defconfig > +++ b/configs/rock-pi-4-rk3399_defconfig > @@ -10,6 +10,8 @@ CONFIG_ROCKCHIP_RK3399=y > CONFIG_TARGET_EVB_RK3399=y > CONFIG_DEBUG_UART_BASE=0xFF1A0000 > CONFIG_DEBUG_UART_CLOCK=24000000 > +CONFIG_SPL_SPI_FLASH_SUPPORT=y > +CONFIG_SPL_SPI=y > CONFIG_SYS_LOAD_ADDR=0x800800 > CONFIG_DEBUG_UART=y > CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > @@ -28,6 +30,10 @@ CONFIG_SPL_BSS_MAX_SIZE=0x2000 > CONFIG_SPL_STACK=0x400000 > CONFIG_SPL_STACK_R=y > CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x10000 > +CONFIG_SPL_MTD_SUPPORT=y > +CONFIG_SPL_SPI_FLASH_MTD=y > +CONFIG_SPL_SPI_LOAD=y > +CONFIG_SYS_SPI_U_BOOT_OFFS=0xb0000 > CONFIG_TPL=y > CONFIG_CMD_BOOTZ=y > CONFIG_CMD_GPT=y > @@ -40,6 +46,7 @@ CONFIG_SPL_OF_CONTROL=y > CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" > CONFIG_ENV_IS_IN_MMC=y > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > +CONFIG_SPL_DM_SEQ_ALIAS=y > CONFIG_ROCKCHIP_GPIO=y > CONFIG_SYS_I2C_ROCKCHIP=y > CONFIG_MISC=y > @@ -48,21 +55,36 @@ CONFIG_MMC_DW=y > CONFIG_MMC_DW_ROCKCHIP=y > CONFIG_MMC_SDHCI=y > CONFIG_MMC_SDHCI_ROCKCHIP=y > +CONFIG_MTD=y > +CONFIG_DM_MTD=y > +CONFIG_SF_DEFAULT_BUS=1 > +CONFIG_SF_DEFAULT_MODE=0x3 > +CONFIG_SF_DEFAULT_SPEED=40000000 > +CONFIG_SPI_FLASH_SFDP_SUPPORT=y > +CONFIG_SPI_FLASH_SOFT_RESET=y > +CONFIG_SPI_FLASH_SOFT_RESET_ON_BOOT=y > +CONFIG_SPI_FLASH_XTX=y > +CONFIG_SPI_FLASH_MTD=y > CONFIG_DM_ETH=y > CONFIG_ETH_DESIGNWARE=y > CONFIG_GMAC_ROCKCHIP=y > CONFIG_NVME_PCI=y > CONFIG_PCI=y > +CONFIG_SPL_PHY=y > CONFIG_PHY_ROCKCHIP_INNO_USB2=y > CONFIG_PHY_ROCKCHIP_TYPEC=y > +CONFIG_DM_PMIC_FAN53555=y > CONFIG_PMIC_RK8XX=y > CONFIG_REGULATOR_PWM=y > +CONFIG_SPL_REGULATOR_PWM=y > +CONFIG_DM_REGULATOR_GPIO=y > CONFIG_REGULATOR_RK8XX=y > CONFIG_PWM_ROCKCHIP=y > CONFIG_RAM_RK3399_LPDDR4=y > CONFIG_DM_RESET=y > CONFIG_BAUDRATE=1500000 > CONFIG_DEBUG_UART_SHIFT=2 > +CONFIG_ROCKCHIP_SPI=y > CONFIG_SYSRESET=y > CONFIG_USB=y > CONFIG_USB_XHCI_HCD=y