From: "flichtenheld (Code Review)" Date: Wed, 23 Jul 2025 16:59:04 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <90bdbc19df4b8b2f6d3cabead4fb03640c9efca9-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Buwcb4kkBSA="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl: Fix type of sslopts argument to SSL_CTX_set_options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --Buwcb4kkBSA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1101?usp=3Demail to review the following change. Change subject: ssl_openssl: Fix type of sslopts argument to SSL_CTX_set_op= tions ...................................................................... ssl_openssl: Fix type of sslopts argument to SSL_CTX_set_options The argument changed type in OpenSSL 3.0. Change-Id: Ia5e0aad8a97d38f8d309a29ecfe3c578edff9595 Signed-off-by: Frank Lichtenheld --- M src/openvpn/ssl_openssl.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/01/1101/1 diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index 4c11cd4..ea9fec0 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -312,7 +312,7 @@ ASSERT(NULL !=3D ctx); /* process SSL options */ - long sslopt =3D SSL_OP_SINGLE_DH_USE | SSL_OP_NO_TICKET; + uint64_t sslopt =3D SSL_OP_SINGLE_DH_USE | SSL_OP_NO_TICKET; #ifdef SSL_OP_CIPHER_SERVER_PREFERENCE sslopt |=3D SSL_OP_CIPHER_SERVER_PREFERENCE; #endif -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1101?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia5e0aad8a97d38f8d309a29ecfe3c578edff9595 Gerrit-Change-Number: 1101 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --Buwcb4kkBSA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

ssl_openssl: Fix type of sslopts argument to SSL_CTX_set_opt=
ions

The argument changed type in OpenSSL 3.0.

Change-Id: Ia5= e0aad8a97d38f8d309a29ecfe3c578edff9595
Signed-off-by: Frank Lichtenheld = <frank@...2641...>
---
M src/openvpn/ssl_openssl.c
1 file ch= anged, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.openvp=
n.net:29418/openvpn refs/changes/01/1101/1
diff --git a/src/openvpn=
/ssl_openssl.c b/src/openvpn/ssl_openssl.c
index 4c11cd4..e= a9fec0 100644
--- a/src/openvpn/ssl_openssl.c
+++ b/src/openvpn/ssl_openssl.c
@@ -312,7 +312,7 @@
ASSERT(NULL !=3D ctx);

= /* process SSL options */
- long sslopt =3D SSL_OP_SINGLE_DH_USE | SSL_OP_NO_TICKET;=
+ uint64_t sslopt =3D SS= L_OP_SINGLE_DH_USE | SSL_OP_NO_TICKET;
#ifdef SSL_OP_CIPHE= R_SERVER_PREFERENCE
sslopt |=3D SSL_OP_CIPHER_SERVER_P= REFERENCE;
#endif

To v= iew, visit change 1101. To unsubscribe, or for help writing mail filters, visit= settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia5e0aad8a97d38f8d309a29ecfe= 3c578edff9595
Gerrit-Change-Number: 1101
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--Buwcb4kkBSA=--