From: Alex Marginean Date: Fri, 9 Aug 2019 16:17:07 +0300 Subject: [U-Boot] [PATCH 06/11] drivers: net: aquantia: set MDI reversal based on DT property In-Reply-To: <20190808164520.32600-7-alexandru.marginean@nxp.com> References: <20190808164520.32600-1-alexandru.marginean@nxp.com> <20190808164520.32600-7-alexandru.marginean@nxp.com> Message-ID: <91037c1b-da4b-773e-98bf-238e92d9cc71@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 8/8/2019 7:45 PM, Alex Marginean wrote: > MDI pins up to the RJ45 connector may be reversed on the board and the > default PHY configuration applied by firmware may or may not match that. > Add an optional DT property to configure MDI reversal for this case. > > Signed-off-by: Alex Marginean > --- > drivers/net/phy/aquantia.c | 39 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c > index ab165e76f5..62a4d1ea6e 100644 > --- a/drivers/net/phy/aquantia.c > +++ b/drivers/net/phy/aquantia.c > @@ -64,6 +64,13 @@ > #define UP_RUN_STALL_OVERRIDE BIT(6) > #define UP_RUN_STALL BIT(0) > > +#define AQUANTIA_PMA_RX_VENDOR_P1 0xe400 > +#define AQUANTIA_PMA_RX_VENDOR_P1_MDI_MSK GENMASK(1, 0) > +/* MDI reversal configured through registers */ > +#define AQUANTIA_PMA_RX_VENDOR_P1_MDI_CFG BIT(1) > +/* MDI reversal enabled */ > +#define AQUANTIA_PMA_RX_VENDOR_P1_MDI_REV BIT(0) > + > /* > * global start rate, the protocol associated with this speed is used by default > * on SI. > @@ -324,6 +331,36 @@ static int aquantia_set_proto(struct phy_device *phydev, int if_type) > return 0; > } > > +static int aquantia_dts_config(struct phy_device *phydev) > +{ > +#ifdef CONFIG_OF_CONTROL ^ This should be CONFIG_DM_ETH > + ofnode node = phydev->node; > + u32 prop; > + u16 reg; > + > + /* this code only works on gen2 and gen3 PHYs */ > + if (phydev->drv->data != AQUANTIA_GEN2 && > + phydev->drv->data != AQUANTIA_GEN3) > + return -ENOTSUPP; > + > + if (!ofnode_valid(node)) > + return 0; > + > + if (!ofnode_read_u32(node, "mdi-reversal", &prop)) { > + debug("mdi-reversal = %d\n", (int)prop); > + reg = phy_read(phydev, MDIO_MMD_PMAPMD, > + AQUANTIA_PMA_RX_VENDOR_P1); > + reg &= ~AQUANTIA_PMA_RX_VENDOR_P1_MDI_MSK; > + reg |= AQUANTIA_PMA_RX_VENDOR_P1_MDI_CFG; > + reg |= prop ? AQUANTIA_PMA_RX_VENDOR_P1_MDI_REV : 0; > + phy_write(phydev, MDIO_MMD_PMAPMD, AQUANTIA_PMA_RX_VENDOR_P1, > + reg); > + } > + > +#endif > + return 0; > +} > + > static bool aquantia_link_is_up(struct phy_device *phydev) > { > u16 reg, regmask; > @@ -403,6 +440,8 @@ int aquantia_config(struct phy_device *phydev) > > /* configure protocol based on phydev->interface */ > aquantia_set_proto(phydev, if_type); > + /* apply custom configuration based on DT */ > + aquantia_dts_config(phydev); > > /* wake PHY back up */ > phy_write(phydev, MDIO_MMD_VEND1, AQUANTIA_VND1_GLOBAL_SC, 0); >