Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D482FC43603 for ; Thu, 19 Dec 2019 09:39:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A66CE24679 for ; Thu, 19 Dec 2019 09:39:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A66CE24679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 455666EAEE; Thu, 19 Dec 2019 09:39:56 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F65C6EAEE for ; Thu, 19 Dec 2019 09:39:55 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2019 01:39:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,331,1571727600"; d="scan'208";a="212960518" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga007.fm.intel.com with ESMTP; 19 Dec 2019 01:39:53 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.130]) by IRSMSX106.ger.corp.intel.com ([169.254.8.26]) with mapi id 14.03.0439.000; Thu, 19 Dec 2019 09:39:52 +0000 From: "Kahola, Mika" To: "intel-gfx@lists.freedesktop.org" , "Deak, Imre" Thread-Topic: [Intel-gfx] [PATCH 02/15] drm/i915: Use intel_tile_height() instead of re-implementing Thread-Index: AQHVtb3ZPXNRaVIlv0ytCOcL+aOlcKfBNQoA Date: Thu, 19 Dec 2019 09:39:52 +0000 Message-ID: <9193ebcd1322a583860c4edbe7fd22e6b65698fc.camel@intel.com> References: <20191218161105.30638-1-imre.deak@intel.com> <20191218161105.30638-3-imre.deak@intel.com> In-Reply-To: <20191218161105.30638-3-imre.deak@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.72.159] Content-ID: MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 02/15] drm/i915: Use intel_tile_height() instead of re-implementing X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Pandiyan, Dhinakaran" Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 2019-12-18 at 18:10 +0200, Imre Deak wrote: > From: Dhinakaran Pandiyan > = > intel_tile_dims() computes tile height using size and width, when > there > is already a function to do just that - intel_tile_height() > = > Cc: Ville Syrj=E4l=E4 > Cc: Matt Roper > Signed-off-by: Dhinakaran Pandiyan > Signed-off-by: Imre Deak Reviewed-by: Mika Kahola > --- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > b/drivers/gpu/drm/i915/display/intel_display.c > index 25af0ffe1c3a..928a581336a7 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -1997,7 +1997,7 @@ static void intel_tile_dims(const struct > drm_framebuffer *fb, int color_plane, > unsigned int cpp =3D fb->format->cpp[color_plane]; > = > *tile_width =3D tile_width_bytes / cpp; > - *tile_height =3D intel_tile_size(to_i915(fb->dev)) / > tile_width_bytes; > + *tile_height =3D intel_tile_height(fb, color_plane); > } > = > unsigned int _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx