From: Balakrishna Godavarthi Subject: Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts Date: Wed, 24 Apr 2019 12:38:44 +0530 Message-ID: <91deac040a35235e52079cdbdef2f425@codeaurora.org> References: <20190418132123.12816-1-bgodavar@codeaurora.org> <371A1719-7CDD-4940-9D6F-0F3339FA50E6@holtmann.org> <96d661afb42cd4c6605cf7e2fbec7478@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <96d661afb42cd4c6605cf7e2fbec7478@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Harish Bandi Cc: Marcel Holtmann , Johan Hedberg , Matthias Kaehlcke , Linux Kernel Mailing List , linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-bluetooth-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Hi Harish, On 2019-04-24 12:34, Harish Bandi wrote: > Hi Balakrishna, > > On 2019-04-23 22:05, Marcel Holtmann wrote: >> Hi Balakrishna, >> >>> When flag HCI_QUIRK_USE_BDADDR_PROPERTY is set, we will read the >>> bluetooth address from dts. If the bluetooth address node is missing >>> from the dts we will enable it controller UNCONFIGURED state. >>> This patch enables the normal flow even if the BD address is missing >>> from the dts tree. >>> >>> Signed-off-by: Balakrishna Godavarthi >>> --- >>> net/bluetooth/hci_core.c | 2 -- >>> 1 file changed, 2 deletions(-) >> >> can I get an ACK for this one? >> >> Regards >> >> Marcel > > nit: it would be better if we print error message, if bd address > missing in dts. > > tested 20 times with bd address missing in dts. > tested 20 times with bd address available in dts. > > Tested-by: Harish Bandi > > > Thanks, > Harish Thanks for testing will note this improvement and send an incremental patch. -- Regards Balakrishna.