From: "flichtenheld (Code Review)" Date: Wed, 14 Jan 2026 16:01:00 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <91f36730ba98e6875a23faf60dc0917f225e71db-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="UIVUGDRr16g="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Silence compiler truncation warning by checking snprintf return value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --UIVUGDRr16g= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerr= it.openvpn.net/c/openvpn/+/1272?usp=3Demail ) Change subject: Silence compiler truncation warning by checking snprintf re= turn value ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: Hi. Had ignored this for a while mostly because mingw 13.0.0 isn't present = in our buildbot fleet, yet. But tested it now and it indeed resolves the is= sue. But see comments about error handling. File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/1272/comment/8ce84b65_d5cb1a44?usp=3D= email : PS3, Line 3565: M_FATAL I think M_FATAL is too drastic here. A continue would also be okay, like we= do for errors on RegOpenKeyEx a few lines below. http://gerrit.openvpn.net/c/openvpn/+/1272/comment/3f5b513f_6359ba5c?usp=3D= email : PS3, Line 3680: msg(M_FATAL, "Error constructing connection str= ing for %s", enum_name); I think M_FATAL is too drastic here. A continue would also be okay, like we= do for errors on RegOpenKeyEx a few lines below. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1272?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I54b11a5540fb236580a3b80c6d1e8678b24bd852 Gerrit-Change-Number: 1272 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Wed, 14 Jan 2026 16:01:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --UIVUGDRr16g= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

Patch set 3:Code-Review -1=

V= iew Change

3 comments:

  • Patchset:

    • Patch Set #3:

      Hi. Had ig= nored this for a while mostly because mingw 13.0.0 isn't present in our= buildbot fleet, yet. But tested it now and it indeed resolves the issue. B= ut see comments about error handling.

  • File src/openvpn/tun.c:

    • Patch Set #3, Line 3565: M_FATAL

      I think M_FATAL= is too drastic here. A continue would also be okay, like we do for errors = on RegOpenKeyEx a few lines below.

    • Patch Set = #3, Line 3680: = msg(M_FATAL, "Error constructing connection string for %s", e= num_name);

      I think M_FATAL is too drastic here. A continue would= also be okay, like we do for errors on RegOpenKeyEx a few lines below.

      =

To view, visit change 1272. To unsubscribe, or for help = writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I54b11a5540fb236580a3b80c6d1= e8678b24bd852
Gerrit-Change-Number: 1272
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Wed, 14 Jan 2026 16:01:00= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --UIVUGDRr16g=--