Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4863A1A3178 for ; Fri, 1 Aug 2025 12:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754052944; cv=none; b=PdUYsZDqX7pDPwdnV+70yI2tsbx1n40yJrO0wbFa10OO67hM9DWOiiVEr4hrxZTv8f8rTD4fKiR04pvfz0XHIN3ciMVWgCNQ3QzYX111uTMMIQTbw0SAddqRyEx6Dw7bpmMd6tinB+TJbdTw/0JhV9ezjwR3wgVZyJ+Q5HCpANQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754052944; c=relaxed/simple; bh=aWWfX/xPEC8581xAdLGhfBZlNh4aqmwNA/oS0MaqVHc=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=PTweDe2mDEHazCQ9FUQUPelGfiDknd6p5JusV5Nln/g91PYFBEesWONAm06DOx60g7mxKAHONWPOqv/F3KPQYCYG2u9yonzqsI5OLcIUsRAx+xAbxE4B/4tV58sKq+f3DdfOftWd8Zdw0nZtcGZeakzIINkpQIrVP2KKtYr7j3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hHnePZ8M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hHnePZ8M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C4FAC4CEE7; Fri, 1 Aug 2025 12:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754052943; bh=aWWfX/xPEC8581xAdLGhfBZlNh4aqmwNA/oS0MaqVHc=; h=Date:Subject:To:References:Cc:From:In-Reply-To:From; b=hHnePZ8MGHWeocyhf4BuF8khEYsjk1DH2lGGqKTi98+os6LrZEcCqx7X9nakwpvbt NYw3zo5pAL22mBVm4iPytzgIdGv7qbmpbIdFgs4NjlQ/xbHgzPeCiZAL51k3njRazs mBG3bM4EDogwOJJ362lZF0F+U0geP5q4bshRApsIpr2lSOEPvc0KaqepSzb0DefEbk buHajdecl/J/fPiVchLNbYtxo3rml4EOuKlYDO4Js/Z/hBxekJo3F3dv+NOrOvGhhL UO3J2eZbEhRqFQ/UWcgSfp7npA4gDQmOPRsontUHiHF5BMuJcZTfKq43GkkfC7jXBs Hf4DZ232k7/KQ== Message-ID: <91f83d54-8375-4016-ab53-7a210437d39b@kernel.org> Date: Fri, 1 Aug 2025 08:55:42 -0400 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/9] all: run black To: Daniel Gomez References: <20250730060147.182140-1-mcgrof@kernel.org> <20250730060147.182140-8-mcgrof@kernel.org> Content-Language: en-US Cc: Luis Chamberlain , Daniel Gomez , kdevops@lists.linux.dev From: Chuck Lever Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/25 4:12 AM, Daniel Gomez wrote: > > > On 31/07/2025 14.57, Daniel Gomez wrote: >> On 30/07/2025 08.01, Luis Chamberlain wrote: >>> Run black to fix tons of styling issues with tons of Python scripts. >>> In order to help bots ensure they don't add odd styling we need a >>> convention. >>> >>> Signed-off-by: Luis Chamberlain >> >> Acked-by: Daniel Gomez >> >> FYI, I'm working on b4 check stuff mentioned in the other thread. I think this >> is really nice but it would be awesome to also extend it to Ansible files using >> the Ansible linter: >> >> ansible-lint --help >> {...} >> --fix [WRITE_LIST] Allow ansible-lint to perform auto-fixes, including YAML >> reformatting I use ansible-lint extensively before commit. Linting existing kdevops files is still a bit of jungle, so ansible-lint would have to be directed only at new files. >> So, these changes with black/ansible-lint, etc make sense if: >> 1. Add b4 integration >> 2. Make CI run the scripts as well (make style, make check, etc) >> >> But I suspect a minimal testing may be needed. >> >> Thoughts? > > I'll send an RFC with more details. -- Chuck Lever