Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 038B6C4363A for ; Tue, 20 Oct 2020 15:06:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59B2722247 for ; Tue, 20 Oct 2020 15:06:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="UkE3XIN0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59B2722247 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.9689.25482 (Exim 4.92) (envelope-from ) id 1kUtD2-0007BZ-34; Tue, 20 Oct 2020 15:05:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 9689.25482; Tue, 20 Oct 2020 15:05:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUtD2-0007BS-0E; Tue, 20 Oct 2020 15:05:56 +0000 Received: by outflank-mailman (input) for mailman id 9689; Tue, 20 Oct 2020 15:05:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUtD1-0007BN-Ib for xen-devel@lists.xenproject.org; Tue, 20 Oct 2020 15:05:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 230a6fe0-aef5-4c56-a8ff-67cc8404a2cc; Tue, 20 Oct 2020 15:05:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CCCA4AD52; Tue, 20 Oct 2020 15:05:53 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUtD1-0007BN-Ib for xen-devel@lists.xenproject.org; Tue, 20 Oct 2020 15:05:55 +0000 X-Inumbo-ID: 230a6fe0-aef5-4c56-a8ff-67cc8404a2cc Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 230a6fe0-aef5-4c56-a8ff-67cc8404a2cc; Tue, 20 Oct 2020 15:05:54 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603206353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVqXOwluPVtwIxnZpXjiQN1OuEFTkA7XQpwqBQ4VJZY=; b=UkE3XIN0ss6kNgDzOf9CddCHiEv2CPCt6W1cigrUoh5pW2tWa8ttqjjyDPPlgWyDKA52Vb 3tpsSe4plm1cMIvp5lfOABTG6S/xsCwYf0sXjXEij7VWxMEuHqFrfpFMZlmi+qhCq+WU6T SVX8OcVNafKlAk9hFVTTkfvUum5IsQE= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CCCA4AD52; Tue, 20 Oct 2020 15:05:53 +0000 (UTC) Subject: Re: [PATCH] IOMMU: avoid double flushing in shared page table case To: Julien Grall Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , Stefano Stabellini , Kevin Tian , Jun Nakajima , Paul Durrant References: <01a5840e-3250-246c-8d38-29a65d4937ea@xen.org> From: Jan Beulich Message-ID: <91fc14a3-6bc0-5929-2087-e4f57901fe14@suse.com> Date: Tue, 20 Oct 2020 17:05:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <01a5840e-3250-246c-8d38-29a65d4937ea@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 20.10.2020 17:00, Julien Grall wrote: > On 20/10/2020 14:52, Jan Beulich wrote: >> While the flush coalescing optimization has been helping the non-shared >> case, it has actually lead to double flushes in the shared case (which >> ought to be the more common one nowadays at least): Once from >> *_set_entry() and a second time up the call tree from wherever the >> overriding flag gets played with. In alignment with XSA-346 suppress >> flushing in this case. >> >> Similarly avoid excessive setting of IOMMU_FLUSHF_added on the batched >> flushes: "idx" hasn't been added a new mapping for. >> >> Signed-off-by: Jan Beulich >> --- >> TBD: The Arm part really is just for completeness (and hence could also >> be dropped) - the affected mapping spaces aren't currently >> supported there. > > As I may I have pointed out in the past, there are many ways to screw > things up when using iommu_dont_flush_iotlb. > > So I would rather not introduce any usage on Arm until we see a use-case. "Usage" to me would mean a path actually setting the flag. What I'm adding here, basically as a precautionary measure, is a check of the flag. Does your use of "usage" imply you don't want that either? Just to be sure; I'm okay to drop the Arm part. Jan