From: "plaisthos (Code Review)" Date: Wed, 10 Dec 2025 13:53:32 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., davidben@...410..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <922313d1038bf5c7297b23f24a74b10b9c22fc8d-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="rR/J0xu0Jys="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: ssl_openssl: Fix some CRL mixups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: davidben Cc: flichtenheld , openvpn-devel --rR/J0xu0Jys= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: davidben, flichtenheld. plaisthos has posted comments on this change by davidben. ( http://gerrit.o= penvpn.net/c/openvpn/+/1289?usp=3Demail ) Change subject: ssl_openssl: Fix some CRL mixups ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: So I debugged this further and the root cause is that tls_root_ctx is share= d/copied around between tls_options and key_schedule context. With the old = implementation this was not a problem since the pointer never changed. But = with the new implementation the pointer is freed and changed in one instanc= e and the other instance will then still try to free the old pointer and th= at causes a free on an invalid pointer and that segfaults. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1289?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I31ac2a763209114267c35c4a9182a12d8d82f6fe Gerrit-Change-Number: 1289 Gerrit-PatchSet: 2 Gerrit-Owner: davidben Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: davidben Gerrit-Comment-Date: Wed, 10 Dec 2025 13:53:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No --rR/J0xu0Jys= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: davidben, flichtenheld.

View = Change

1 comment:

    =
  • Patchset:

    • Patch Set #2:

      So I debugged t= his further and the root cause is that tls_root_ctx is shared/copied around= between tls_options and key_schedule context. With the old implementation = this was not a problem since the pointer never changed. But with the new im= plementation the pointer is freed and changed in one instance and the other= instance will then still try to free the old pointer and that causes a fre= e on an invalid pointer and that segfaults.

To vi= ew, visit change 1289. To unsubscribe, or for help writing mail filters, visit = settings.

=
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I31ac2a763209114267c35c4a918= 2a12d8d82f6fe
Gerrit-Change-Number: 1289
Gerrit-PatchSet: 2
Gerrit-Owner: davidben <davidben@...410...&= gt;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: davidben <davidben@...2975...= ...>
Gerrit-Comment-Date: Wed, 10 Dec 2025 13:53:32= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
= --rR/J0xu0Jys=--