From: "cron2 (Code Review)" Date: Mon, 21 Jul 2025 19:21:15 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., marco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <926253eb77676ac83f023b63ea8cd8ef278a4fcf-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ypWNGxvKpZ8="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added update_option() function. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrbff Cc: stipa , plaisthos , flichtenheld , openvpn-devel --ypWNGxvKpZ8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, mrbff, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/810?usp=3Demail ) Change subject: PUSH_UPDATE: Added update_option() function. ...................................................................... Patch Set 21: Code-Review-1 (5 comments) Patchset: PS21: Nagging about code duplication... File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/810/comment/e80b547e_689dbd50 : PS21, Line 5897: } I find this duplication of syntax checking, mmmh, sub-optimal. We'll check= the syntax anyway in `add_option()` later on... I could see user complaints about "I sent a PUSH_UPDATE with one invalid `r= oute` in it, and all my routes were lost", but honestly, do we really care = that much? (If yes, we could consider moving the syntax check into a small= helper, if not, just drop the lines from `rol_check_alloc()` up to this li= ne). http://gerrit.openvpn.net/c/openvpn/+/810/comment/e1f5b5bd_f34b1d7f : PS21, Line 5927: } same here http://gerrit.openvpn.net/c/openvpn/+/810/comment/4054ed13_3dac7037 : PS21, Line 6009: same here... lots of code that needs to be in sync with the add_option() ch= ecks... http://gerrit.openvpn.net/c/openvpn/+/810/comment/abc555fa_e0e5856c : PS21, Line 6045: #endif I note a distinct lack of syntax checking for `dhcp-option` ;-) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/810?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia45c99e6df7b3ad24020c10b8a9b3577984ecdc2 Gerrit-Change-Number: 810 Gerrit-PatchSet: 21 Gerrit-Owner: mrbff Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: mrbff Gerrit-Comment-Date: Mon, 21 Jul 2025 19:21:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --ypWNGxvKpZ8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, mrbff, plaisthos. <= /p>

Patch set 21:Code-Review -1

V= iew Change

5 comments:

  • Patchset:

    • Patch Set #21:

      Nagging about code duplication...

    • <= /ul>
    • File src/openvpn/options.c= :

      • Patch Set #21, Li= ne 5897: }<= /code>

        I find= this duplication of syntax checking, mmmh, sub-optimal. We'll check t= he syntax anyway in `add_option()` later on...

        I could see user complaints about "I= sent a PUSH_UPDATE with one invalid `route` in it, and all my routes were = lost", but honestly, do we really care that much? (If yes, we could c= onsider moving the syntax check into a small helper, if not, just drop the = lines from `rol_check_alloc()` up to this line).

      • Patch Set= #21, Line 5927: = }

        Patch Set #21, Line 6009:

        same here... lots of code that needs to be in s= ync with the add_option() checks...

      • Patch Set #21, Line 60= 45: #endif

        I note a distinct = lack of syntax checking for `dhcp-option` ;-)

    To = view, visit change 810. To unsubscribe, or for help writing mail filters, visit = settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ia45c99e6df7b3ad24020c10b8a9= b3577984ecdc2
    Gerrit-Change-Number: 810
    Gerrit-PatchSet: 21
    Gerrit-Owner: mrbff <marco@...2726...> <= /div>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-Reviewer: stipa <lstipakov@...277...= >
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Attention: mrbff <marco@...2726...&g= t;
    Gerrit-Comment-Date: Mon, 21 Jul 2025 19:21:15= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --ypWNGxvKpZ8=--