From: John Hubbard Subject: Re: [PATCH v6 17/24] mm/gup: track FOLL_PIN pages Date: Tue, 19 Nov 2019 23:17:16 -0800 Message-ID: <92d0385a-90be-e900-e5ec-1eeafd24ff81@nvidia.com> References: <20191119081643.1866232-1-jhubbard@nvidia.com> <20191119081643.1866232-18-jhubbard@nvidia.com> <20191119113746.GD25605@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 246416E05D for ; Wed, 20 Nov 2019 07:17:18 +0000 (UTC) In-Reply-To: <20191119113746.GD25605@quack2.suse.cz> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jan Kara Cc: Michal Hocko , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kerne List-Id: dri-devel@lists.freedesktop.org T24gMTEvMTkvMTkgMzozNyBBTSwgSmFuIEthcmEgd3JvdGU6Cj4gT24gVHVlIDE5LTExLTE5IDAw OjE2OjM2LCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4+IEBAIC0yMDI1LDYgKzIxNDksMjAgQEAgc3Rh dGljIGludCBfX3JlY29yZF9zdWJwYWdlcyhzdHJ1Y3QgcGFnZSAqcGFnZSwgdW5zaWduZWQgbG9u ZyBhZGRyLAo+PiAgCXJldHVybiBucjsKPj4gIH0KPj4gIAo+PiArc3RhdGljIGJvb2wgX19waW5f Y29tcG91bmRfaGVhZChzdHJ1Y3QgcGFnZSAqaGVhZCwgaW50IHJlZnMsIHVuc2lnbmVkIGludCBm bGFncykKPj4gK3sKPiAKPiBJIGRvbid0IHF1aXRlIGxpa2UgdGhlIHByb2xpZmVyYXRpb24gb2Yg bmFtZXMgc3RhcnRpbmcgd2l0aCBfXy4gSSBkb24ndAo+IHRoaW5rIHRoZXJlJ3MgYSBnb29kIHJl YXNvbiBmb3IgdGhhdCwgcGFydGljdWxhcmx5IGluIHRoaXMgY2FzZS4gQWxzbyAncGluJwo+IGhl cmUgaXMgc29tZXdoYXQgbWlzbGVhZGluZyBhcyB3ZSBhbHJlYWR5IHVzZSB0ZXJtICJwaW4iIGZv ciB0aGUgcGFydGljdWxhcgo+IHdheSBvZiBwaW5uaW5nIHRoZSBwYWdlLiBXZSBjb3VsZCBoYXZl IGdyYWJfY29tcG91bmRfaGVhZCgpIG9yIG1heWJlCj4gbmFpbF9jb21wb3VuZF9oZWFkKCkgOiks IGJ1dCB5b3UncmUgbmF0aXZlIHNwZWFrZXIgc28geW91IG1heSBjb21lIHVwIHdpdGgKPiBiZXR0 ZXIgd29yZC4KCgpZZXMsIGl0IGlzIHVnbHkgbmFtaW5nLCBJJ2xsIGNoYW5nZSB0aGVzZSBhcyBm b2xsb3dzOgoKICAgIF9fcGluX2NvbXBvdW5kX2hlYWQoKSAtLT4gZ3JhYl9jb21wb3VuZF9oZWFk KCkgICAgCiAgICBfX3JlY29yZF9zdWJwYWdlcygpICAgLS0+IHJlY29yZF9zdWJwYWdlcygpCgpJ IGxvdmVkIHRoZSAibmFpbF9jb21wb3VuZF9oZWFkKCkiIHN1Z2dlc3Rpb24sIGl0IGp1c3Qgc2Vl bXMgdmVyeSB2aXZpZCwgYnV0CmluIHRoZSBlbmQsIEkgZmlndXJlZCBJJ2QgYmV0dGVyIGtlZXAg aXQgcmVsYXRpdmVseSBkcmFiIGFuZCBjb2xvcmxlc3MuIDopCgo+IAo+PiArCWlmIChmbGFncyAm IEZPTExfUElOKSB7Cj4+ICsJCWlmICh1bmxpa2VseSghdHJ5X3Bpbl9jb21wb3VuZF9oZWFkKGhl YWQsIHJlZnMpKSkKPj4gKwkJCXJldHVybiBmYWxzZTsKPj4gKwl9IGVsc2Ugewo+PiArCQloZWFk ID0gdHJ5X2dldF9jb21wb3VuZF9oZWFkKGhlYWQsIHJlZnMpOwo+PiArCQlpZiAoIWhlYWQpCj4+ ICsJCQlyZXR1cm4gZmFsc2U7Cj4+ICsJfQo+PiArCj4+ICsJcmV0dXJuIHRydWU7Cj4+ICt9Cj4+ ICsKPj4gIHN0YXRpYyB2b2lkIHB1dF9jb21wb3VuZF9oZWFkKHN0cnVjdCBwYWdlICpwYWdlLCBp bnQgcmVmcykKPj4gIHsKPj4gIAkvKiBEbyBhIGdldF9wYWdlKCkgZmlyc3QsIGluIGNhc2UgcmVm cyA9PSBwYWdlLT5fcmVmY291bnQgKi8KPiAKPiBwdXRfY29tcG91bmRfaGVhZCgpIG5lZWRzIHNp bWlsYXIgdHJlYXRtZW50IGFzIHVuZG9fZGV2X3BhZ2VtYXAoKSwgZG9lc24ndAo+IGl0Pwo+IAoK WWVzLCB3aWxsIGZpeCB0aGF0IHVwLgoKCj4+IEBAIC05NjgsNyArOTczLDE4IEBAIHN0cnVjdCBw YWdlICpmb2xsb3dfZGV2bWFwX3BtZChzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwgdW5zaWdu ZWQgbG9uZyBhZGRyLAo+PiAgCWlmICghKnBnbWFwKQo+PiAgCQlyZXR1cm4gRVJSX1BUUigtRUZB VUxUKTsKPj4gIAlwYWdlID0gcGZuX3RvX3BhZ2UocGZuKTsKPj4gLQlnZXRfcGFnZShwYWdlKTsK Pj4gKwo+PiArCWlmIChmbGFncyAmIEZPTExfR0VUKQo+PiArCQlnZXRfcGFnZShwYWdlKTsKPj4g KwllbHNlIGlmIChmbGFncyAmIEZPTExfUElOKSB7Cj4+ICsJCS8qCj4+ICsJCSAqIHRyeV9waW5f cGFnZSgpIGlzIG5vdCBhY3R1YWxseSBleHBlY3RlZCB0byBmYWlsIGhlcmUgYmVjYXVzZQo+PiAr CQkgKiB3ZSBob2xkIHRoZSBwbWQgbG9jayBzbyBubyBvbmUgY2FuIHVubWFwIHRoZSBwbWQgYW5k IGZyZWUgdGhlCj4+ICsJCSAqIHBhZ2UgdGhhdCBpdCBwb2ludHMgdG8uCj4+ICsJCSAqLwo+PiAr CQlpZiAodW5saWtlbHkoIXRyeV9waW5fcGFnZShwYWdlKSkpCj4+ICsJCQlwYWdlID0gRVJSX1BU UigtRUZBVUxUKTsKPj4gKwl9Cj4gCj4gVGhpcyBwYXR0ZXJuIGlzIHJhdGhlciBjb21tb24uIFNv IG1heWJlIEknZCBhZGQgYSBoZWxwZXIgZ3JhYl9wYWdlKHBhZ2UsCj4gZmxhZ3MpIGRvaW5nCj4g Cj4gCWlmIChmbGFncyAmIEZPTExfR0VUKQo+IAkJZ2V0X3BhZ2UocGFnZSk7Cj4gCWVsc2UgaWYg KGZsYWdzICYgRk9MTF9QSU4pCj4gCQlyZXR1cm4gdHJ5X3Bpbl9wYWdlKHBhZ2UpOwo+IAlyZXR1 cm4gdHJ1ZTsKPiAKCk9LLgoKPiBPdGhlcndpc2UgdGhlIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUg bm93Lgo+IAo+IAkJCQkJCQkJSG9uemEKCkdyZWF0ISBJIHRob3VnaHQgSSdkIGhhdmUgYSB2NyBv dXQgdG9kYXksIGJ1dCBmYXRlIGRlY2lkZWQgdG8gaGF2ZSBtZSByZXBhaXIKbXkgdGVzdCBtYWNo aW5lIGluc3RlYWQuIFNvLCBzb29uLiBoYS4gOikKCnRoYW5rcywKLS0gCkpvaG4gSHViYmFyZApO VklESUEKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs