Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63BFD360 for ; Sat, 13 Jan 2024 14:32:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W2iDRHq4" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5534dcfdd61so13002840a12.0 for ; Sat, 13 Jan 2024 06:32:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705156319; x=1705761119; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=APn3iAUNB1nelB0VjjmgE971VUMsEwHYKOcmu8CEFnY=; b=W2iDRHq4V+y1CFZtUvjQojHbaqDnoPuk+FHTHMfRHNCvElsKfbTQyyqprUQ0YTQJPP EgcWyxeNKIjCz2XMVoNLHLmLBR4hwZ7Rmcm0agbN5u9Sq5/BNRwjalcU8F6jDN0HuWDY /8xz42H5Xx/Ui1WQ0e/wL8LZo+HN0sQv3fev0UVj8STSJ1UvQJvb/4MKY0/KxA/9n2Xr 8XDWR4VKoX5OnSix13vVui4auhSRKTaA0oJr5mjnhMfi6iczAevb0r9oVk3AN/wzszoY wMYj9PLVuemq89WQbwQatYxHxWr6HZ+E9iudD5HbikqNmDAm4OeFh5rd+6hVooGN4GFZ lOJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705156319; x=1705761119; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=APn3iAUNB1nelB0VjjmgE971VUMsEwHYKOcmu8CEFnY=; b=AnATPdkIJVs8Mw2ImWB1sx4xHGX9fFwEdsUNKcPG2gyLsOdmMr5pFnbmjM25J1TgMU ejaatE5gAkTjOE+TWzVrLAQgdiyhjMAYIn2ZWNI2QyXAcAg3jDYHjtJf0NgxUQcmNceU 3vTuZrjqdNub3IcInUsQfb01qBq6xx74+nR7YTIp0ophwspmdBlTttP3mrjJxYLL+x1i YHkT8kzJaVN3a65fEYDsym9GsMR8YlIkYQ2yinPV+kVUpx/zYAFpxCUEXDZ2rsvhXS8c YV7qDpagZFg1Xbml594ekwFgJdkMgOZ6m1Tm1ostBjDI0+a54aoW5NNOR433F0SDxP+N p2hA== X-Gm-Message-State: AOJu0YzETbG6imqHysq0I92FTJl6zXQTncX7X6zP9kAq1Dl5MXE41eOq XaWzH2uCGju+gueMn0xvKlp9O+dFnRo= X-Google-Smtp-Source: AGHT+IH1FgBiCw21MmPT7g5jHY0wKnS1p+5SFYMb7/uOhntBX0JuD2mFwd4aX+81RXyL3C4cF1Ojmg== X-Received: by 2002:a05:6402:c0b:b0:558:89b5:fb72 with SMTP id co11-20020a0564020c0b00b0055889b5fb72mr3979378edb.13.1705156319405; Sat, 13 Jan 2024 06:31:59 -0800 (PST) Received: from ?IPV6:2a01:c22:6f53:1400:f940:1690:80f6:61b6? (dynamic-2a01-0c22-6f53-1400-f940-1690-80f6-61b6.c22.pool.telefonica.de. [2a01:c22:6f53:1400:f940:1690:80f6:61b6]) by smtp.googlemail.com with ESMTPSA id q11-20020aa7d44b000000b00555fd008741sm3013247edr.95.2024.01.13.06.31.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jan 2024 06:31:59 -0800 (PST) Message-ID: <92eff1db-004c-4c08-9dd3-ae094d8dd316@gmail.com> Date: Sat, 13 Jan 2024 15:31:58 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC net-next 0/2] net: dsa: realtek: fix LED support for rtl8366rb To: Luiz Angelo Daros de Luca , Christian Marangi Cc: linus.walleij@linaro.org, alsi@bang-olufsen.dk, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, arinc.unal@arinc9.com, netdev@vger.kernel.org References: <20240106184651.3665-1-luizluca@gmail.com> <659b1106.050a0220.66c7.9f80@mx.google.com> <659bf414.050a0220.32376.5383@mx.google.com> Content-Language: en-US From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13.01.2024 15:24, Luiz Angelo Daros de Luca wrote: >> I'll try to get who scheduled the work and the stack from there. It >> might already pinpoint the cause. Checking if the work is pending >> during netdev trigger activation might also help. I'll also try to >> flush (or cancel) the work before activating the new trigger. I just >> don't know if I can flush (and that way, blocking) inside >> led_set_brightness(). >> > > Hi Christian, > > I got it. It was actually from the netdev trigger. During activation we have: > > /* Check if hw control is active by default on the LED. > * Init already enabled mode in hw control. > */ > if (supports_hw_control(led_cdev)) { > dev = led_cdev->hw_control_get_device(led_cdev); > if (dev) { > const char *name = dev_name(dev); > > set_device_name(trigger_data, name, strlen(name)); > trigger_data->hw_control = true; > > rc = led_cdev->hw_control_get(led_cdev, &mode); > if (!rc) > trigger_data->mode = mode; > } > } > > The set_device_name calls set_baseline_state() that, at this point, > will start to monitor the device using sw control > (trigger_data->hw_control is only set afterwards). In > set_baseline_state(), it will call led_set_brightness in most > codepaths (all of them if trigger_data->hw_control is false). With > link down (and other situations), it will call > led_set_brightness(led_cdev, LED_OFF). If that led_set_brightness > takes some time to be processed, it will happen after the hw control > was configured, undoing what it previously just did. > > Is there any good reason to call set_device_name before the led mode > and hw_control are defined? Will this break anything? > > diff --git a/drivers/leds/trigger/ledtrig-netdev.c > b/drivers/leds/trigger/ledtrig-netdev.c > index d76214fa9ad8..6f72d55c187a 100644 > --- a/drivers/leds/trigger/ledtrig-netdev.c > +++ b/drivers/leds/trigger/ledtrig-netdev.c > @@ -572,12 +572,13 @@ static int netdev_trig_activate(struct > led_classdev *led_cdev) > if (dev) { > const char *name = dev_name(dev); > > - set_device_name(trigger_data, name, strlen(name)); > trigger_data->hw_control = true; > > rc = led_cdev->hw_control_get(led_cdev, &mode); > if (!rc) > trigger_data->mode = mode; > + > + set_device_name(trigger_data, name, strlen(name)); > } > } > > With this patch, it will not undo the trigger setting in hardware > anymore. However, it now calls the hw_control_set 3 times during > activation: > This is addressed by the following patch, it should show up in linux-next after the merge window. https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/commit/?h=for-leds-next-next&id=5df2b4ed10a4ea636bb5ace99712a7d0c6226a55 > 1) set_device_name > 2) register_netdevice_notifier on NETDEV_REGISTER > 3) register_netdevice_notifier on NETDEV_UP > > Anyway, calling it multiple times doesn't break anything. > > Regards, > > Luiz >