Message-ID: <92f821cd-5fff-9dca-7e63-e33dfc7b391a@gmail.com>
Date: Mon, 21 Feb 2022 01:53:51 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 5/8] media: staging: tegra-vde: Bump BSEV DMA timeout
Content-Language: en-US
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>,
 Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil
 <hverkuil@xs4all.nl>, Nicolas Dufresne <nicolas@ndufresne.ca>,
 Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
 linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220220204623.30107-1-digetx@gmail.com>
 <20220220204623.30107-6-digetx@gmail.com>
In-Reply-To: <20220220204623.30107-6-digetx@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

20.02.2022 23:46, Dmitry Osipenko пишет:
> BSEV DMA timeouts if VDE is downclocked by x10. Bump the timeout to allow
> DMA to complete. We don't support freq scaling yet, this is just a minor
> improvement which may become useful sometime later.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/staging/media/tegra-vde/h264.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/tegra-vde/h264.c b/drivers/staging/media/tegra-vde/h264.c
> index a46c648a26c6..d8e5534e80c8 100644
> --- a/drivers/staging/media/tegra-vde/h264.c
> +++ b/drivers/staging/media/tegra-vde/h264.c
> @@ -135,7 +135,7 @@ static int tegra_vde_wait_bsev(struct tegra_vde *vde, bool wait_dma)
>  		return 0;
>  
>  	err = readl_relaxed_poll_timeout(vde->bsev + INTR_STATUS, value,
> -					 !(value & BSE_DMA_BUSY), 1, 100);
> +					 !(value & BSE_DMA_BUSY), 1, 1000);
>  	if (err) {
>  		dev_err(dev, "BSEV DMA timeout\n");
>  		return err;

For the reference: This is a new patch in v4/v5 and I didn't intend to
include it into this patchset, it happened by accident. On the other
hand, this patch is harmless, so it's okay to keep it.