From: David Howells Subject: Re: [PATCH] rxrpc: Fix uninitialized error code in rxrpc_send_data_packet() Date: Tue, 04 Jun 2019 08:34:13 +0100 Message-ID: <9306.1559633653@warthog.procyon.org.uk> References: <20190528142424.19626-1-geert@linux-m68k.org> <20190528142424.19626-3-geert@linux-m68k.org> <15499.1559298884@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2D18EF896CE for ; Tue, 4 Jun 2019 09:34:42 +0200 (CEST) In-Reply-To: Content-ID: <9305.1559633653.1@warthog.procyon.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Geert Uytterhoeven Cc: linux-block@vger.kernel.org, ALSA Development Mailing List , linux-afs@lists.infradead.org, Linux Kernel Mailing List , Arnd Bergmann , "David S . Miller" , netdev , Takashi Iwai , Clemens Ladisch , Jamal Hadi Salim , dhowells@redhat.com, Jiri Pirko , Cong Wang , Joe Perches , "Mohit P . Tahiliani" , Matias Bjorling , Eran Ben Elisha , Dan Carpenter , Igor Konopko List-Id: alsa-devel@alsa-project.org Geert Uytterhoeven wrote: > I'm not such a big fan of BUG(), so I'd go for ret = -EAFNOSUPPORT, but given > rxrpc is already full of BUG() calls, I guess it is an acceptable solution. Okay. Are you okay with this going through net-next? David