From: "d12fk (Code Review)" Date: Sat, 5 Apr 2025 04:11:35 +0000 In-Reply-To: References: Reply-To: heiko@...515..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <937e916354568ee0bbb8d12c81347018e83e86af-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="5j3teeVQJAs="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stipa , flichtenheld , plaisthos , openvpn-devel --5j3teeVQJAs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/837?usp=3Demail ) Change subject: win: implement --dns option support with NRPT ...................................................................... Patch Set 16: (1 comment) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/837/comment/a8476c39_19850a6f : PS15, Line 2187: err =3D RegGetValueW(itf, NULL, values[i], RRF_RT_= REG_SZ, NULL, (PBYTE)domains, size); > For existing but empty values, the size will be set to 2. [=E2=80=A6] Very nice find. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc Gerrit-Change-Number: 837 Gerrit-PatchSet: 16 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: stipa Gerrit-Comment-Date: Sat, 05 Apr 2025 04:11:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa Gerrit-MessageType: comment --5j3teeVQJAs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos, stipa.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpnserv/interactive.c:<= /p>

    • Patch Set #15, Line= 2187: err =3D = RegGetValueW(itf, NULL, values[i], RRF_RT_REG_SZ, NULL, (PBYTE)domains, siz= e);

      For existing but empty values, the size will be s= et to 2. [=E2=80=A6]

      Very nice find.

To view, vis= it change= 837. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5= adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 16
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Sat, 05 Apr 2025 04:11:35= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipakov@...1664...= 7...>
Gerrit-MessageType: comment
--5j3teeVQJAs=--