Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A4B4C433EF for ; Tue, 26 Jul 2022 06:42:05 +0000 (UTC) Received: from localhost ([::1]:53448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGEGa-00079Y-6M for qemu-devel@archiver.kernel.org; Tue, 26 Jul 2022 02:42:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGEEb-0006Ly-Qt for qemu-devel@nongnu.org; Tue, 26 Jul 2022 02:40:02 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:50340) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGEER-0007UX-U1 for qemu-devel@nongnu.org; Tue, 26 Jul 2022 02:39:54 -0400 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R201e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018046049; MF=kangjie.xu@linux.alibaba.com; NM=1; PH=DS; RN=5; SR=0; TI=SMTPD_---0VKU8jp-_1658817581; Received: from 30.227.68.147(mailfrom:kangjie.xu@linux.alibaba.com fp:SMTPD_---0VKU8jp-_1658817581) by smtp.aliyun-inc.com; Tue, 26 Jul 2022 14:39:42 +0800 Message-ID: <93985df7-7d5f-782e-10ed-7494f0806d22@linux.alibaba.com> Date: Tue, 26 Jul 2022 14:39:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 08/16] vhost: add op to enable or disable a single vring To: Jason Wang References: <8bf7574d8e133d3fa7e8b09f4deb59369916774a.1658141552.git.kangjie.xu@linux.alibaba.com> From: Kangjie Xu Cc: mst@redhat.com, qemu-devel@nongnu.org, xuanzhuo@linux.alibaba.com, hengqi@linux.alibaba.com In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=115.124.30.43; envelope-from=kangjie.xu@linux.alibaba.com; helo=out30-43.freemail.mail.aliyun.com X-Spam_score_int: -98 X-Spam_score: -9.9 X-Spam_bar: --------- X-Spam_report: (-9.9 / 5.0 requ) BAYES_00=-1.9, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2022/7/26 11:49, Jason Wang 写道: > > 在 2022/7/18 19:17, Kangjie Xu 写道: >> The interface to set enable status for a single vring is lacked in >> VhostOps, since the vhost_set_vring_enable_op will manipulate all >> virtqueues in a device. >> >> Resetting a single vq will rely on this interface. It requires a >> reply to indicate that the reset operation is finished, so the >> parameter, wait_for_reply, is added. > > > The wait reply seems to be a implementation specific thing. Can we > hide it? > > Thanks > I do not hide wait_for_reply here because when stopping the queue, a reply is needed to ensure that the message has been processed and queue has been disabled. When restarting the queue, we do not need a reply, which is the same as what qemu does in vhost_dev_start(). So I add this parameter to distinguish the two cases. I think one alternative implementation is to add a interface in VhostOps: queue_reset(). In this way details can be hidden. What do you think of this solution? Does it look better? Thanks > >> >> Signed-off-by: Kangjie Xu >> Signed-off-by: Xuan Zhuo >> --- >>   include/hw/virtio/vhost-backend.h | 4 ++++ >>   1 file changed, 4 insertions(+) >> >> diff --git a/include/hw/virtio/vhost-backend.h >> b/include/hw/virtio/vhost-backend.h >> index eab46d7f0b..7bddd1e9a0 100644 >> --- a/include/hw/virtio/vhost-backend.h >> +++ b/include/hw/virtio/vhost-backend.h >> @@ -81,6 +81,9 @@ typedef int (*vhost_set_backend_cap_op)(struct >> vhost_dev *dev); >>   typedef int (*vhost_set_owner_op)(struct vhost_dev *dev); >>   typedef int (*vhost_reset_device_op)(struct vhost_dev *dev); >>   typedef int (*vhost_get_vq_index_op)(struct vhost_dev *dev, int idx); >> +typedef int (*vhost_set_single_vring_enable_op)(struct vhost_dev *dev, >> +                                                int index, int enable, >> +                                                bool wait_for_reply); >>   typedef int (*vhost_set_vring_enable_op)(struct vhost_dev *dev, >>                                            int enable); >>   typedef bool (*vhost_requires_shm_log_op)(struct vhost_dev *dev); >> @@ -155,6 +158,7 @@ typedef struct VhostOps { >>       vhost_set_owner_op vhost_set_owner; >>       vhost_reset_device_op vhost_reset_device; >>       vhost_get_vq_index_op vhost_get_vq_index; >> +    vhost_set_single_vring_enable_op vhost_set_single_vring_enable; >>       vhost_set_vring_enable_op vhost_set_vring_enable; >>       vhost_requires_shm_log_op vhost_requires_shm_log; >>       vhost_migration_done_op vhost_migration_done;