From: "reynir (Code Review)" Date: Mon, 22 Apr 2024 11:19:41 +0000 In-Reply-To: References: Reply-To: reynir@...2756..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <93a6b5fdf4825172950f79c3dc1b20397b207175-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="LIgbzZ1QQQs="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Only schedule_exit() once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --LIgbzZ1QQQs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. reynir has posted comments on this change. ( http://gerrit.openvpn.net/c/op= envpn/+/555?usp=3Demail ) Change subject: Only schedule_exit() once ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/555/comment/3395ca91_15f2e5ca : PS1, Line 523: * only ever seems to be SIGTERM anyway. */ I also considered dropping the `signal` argument as it is currently always = `SIGTERM` at all call sites. http://gerrit.openvpn.net/c/openvpn/+/555/comment/f2f84020_796d7125 : PS1, Line 530: event_timeout_init(&c->c2.scheduled_exit, n_seconds, now= ); I have only now thought of it: what if the new `n_seconds` is sooner than t= he already scheduled exit?! I suspect `n_seconds` is always 5, though. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/555?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9457f005f4ba970502e6b667d9dc4299a588d661 Gerrit-Change-Number: 555 Gerrit-PatchSet: 1 Gerrit-Owner: reynir Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: reynir Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 22 Apr 2024 11:19:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --LIgbzZ1QQQs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 1:Code-Review -1=

Vi= ew Change

2 comments:

  • File src/openvpn/forward.c:

    =
    • Patch Set #1, Line 523= : * only ever seem= s to be SIGTERM anyway. */

      I also considered dropping the `signal` argument as it= is currently always `SIGTERM` at all call sites.

    • Patch Se= t #1, Line 530: eve= nt_timeout_init(&c->c2.scheduled_exit, n_seconds, now);

      I have only now th= ought of it: what if the new `n_seconds` is sooner than the already schedul= ed exit?! I suspect `n_seconds` is always 5, though.

  • To view, visit change 555. To unsubscribe, or for help writing mail filters,= visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I9457f005f4ba970502e6b667d9d= c4299a588d661
    Gerrit-Change-Number: 555
    Gerrit-PatchSet: 1
    Gerrit-Owner: reynir <reynir@...2756...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-Reviewer: reynir <reynir@...2756...&= gt;
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Mon, 22 Apr 2024 11:19:41= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --LIgbzZ1QQQs=--