From: "flichtenheld (Code Review)" Date: Tue, 13 Jan 2026 15:42:25 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <93b518754f4ffedff631dd76dc382abb70a99d20-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="OHqitZoUrN0="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: error: Remove our implementation of static_assert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --OHqitZoUrN0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1471?usp=3Demail to review the following change. Change subject: error: Remove our implementation of static_assert ...................................................................... error: Remove our implementation of static_assert It is C11, so it should be present in all our compilers. Change-Id: I9cb14b9f44409ec5c78044ddb216a2b4dced0f9b Signed-off-by: Frank Lichtenheld --- M src/openvpn/error.h 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/1471/1 diff --git a/src/openvpn/error.h b/src/openvpn/error.h index 44572b4..1198994 100644 --- a/src/openvpn/error.h +++ b/src/openvpn/error.h @@ -245,14 +245,6 @@ #endif ; -/* Poor-man's static_assert() for when not supplied by assert.h, taken from - * Linux's sys/cdefs.h under GPLv2 */ -#ifndef static_assert -#define static_assert(expr, diagnostic) \ - extern int (*__OpenVPN_static_assert_function( \ - void))[!!sizeof(struct { int __error_if_negative : (expr) ? 2 : -1= ; })] -#endif - /* Inline functions */ static inline bool -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1471?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9cb14b9f44409ec5c78044ddb216a2b4dced0f9b Gerrit-Change-Number: 1471 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --OHqitZoUrN0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

error: Remove our implementation of static_=
assert

It is C11, so it should be present in all our
compilers.
Change-Id: I9cb14b9f44409ec5c78044ddb216a2b4dced0f9b
Signed-off-by= : Frank Lichtenheld <frank@...2641...>
---
M src/openvpn/error.= h
1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/1471/1=
diff --git a/src/openvpn/error.h b/src/openvpn/error.h
<= span>index 44572b4..1198994 100644
--- a/src/openvpn/error.= h
+++ b/src/openvpn/error.h
@@ -245,14 +245= ,6 @@
#endif
;

-/* Poor-man's static_a= ssert() for when not supplied by assert.h, taken from
- * Linux's sys/cdefs.h under GPLv2 */
-#ifndef static_assert
-#define static_assert(e= xpr, diagnostic) \
- extern int (*__OpenVPN_static_assert_function( \
- void))[!!sizeof(struct { int= __error_if_negative : (expr) ? 2 : -1; })]

-#endif
-
/* Inline functions */
static inline bool

To view, vis= it chang= e 1471. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9cb14b9f44409ec5c78044ddb21= 6a2b4dced0f9b
Gerrit-Change-Number: 1471
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --OHqitZoUrN0=--