From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 3/3] drm/amdgpu: replace get_user_pages with HMM address mirror helpers v6 Date: Wed, 6 Feb 2019 10:01:31 +0100 Message-ID: <93d80624-a694-8546-874a-952e36eb3184@gmail.com> References: <20190204182237.2641-1-Philip.Yang@amd.com> <20190204182237.2641-4-Philip.Yang@amd.com> <2e652835-5d7d-3701-b253-99b3797fa52b@amd.com> <9a7d0d7e-79af-69af-5273-8740cd53231d@amd.com> <3751f179-df9c-1934-54a5-4ecf43d02c8d@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <3751f179-df9c-1934-54a5-4ecf43d02c8d-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Yang, Philip" , "Koenig, Christian" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW0gMDUuMDIuMTkgdW0gMjI6NTYgc2NocmllYiBZYW5nLCBQaGlsaXA6Cj4gSGkgQ2hyaXN0aWFu LAo+Cj4gSSB3aWxsIHN1Ym1pdCBuZXcgcGF0Y2ggZm9yIHJldmlldywgbXkgY29tbWVudHMgZW1i ZWRkZWQgaW5saW5lIGJlbG93Lgo+Cj4gVGhhbmtzLAo+IFBoaWxpcAo+Cj4gT24gMjAxOS0wMi0w NSAxOjA5IHAubS4sIEtvZW5pZywgQ2hyaXN0aWFuIHdyb3RlOgo+PiBBbSAwNS4wMi4xOSB1bSAx ODoyNSBzY2hyaWViIFlhbmcsIFBoaWxpcDoKPj4+IFtTTklQXSsKPj4+Pj4gK8KgwqDCoCBpZiAo ciA9PSAtRVJFU1RBUlRTWVMpIHsKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmICghLS10cmllcykg ewo+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBEUk1fRVJST1IoIlBvc3NpYmxlIGRlYWRs b2NrPyBSZXRyeSB0b28gbWFueSB0aW1lc1xuIik7Cj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIHJldHVybiAtRURFQURMSzsKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIH0KPj4+Pj4gK8KgwqDC oMKgwqDCoMKgIGdvdG8gcmVzdGFydDsKPj4+PiBZb3UgcmVhbGx5IG5lZWQgdG8gcmVzdGFydCB0 aGUgSU9DVEwgdG8gcG90ZW50aWFsbHkgaGFuZGxlIHNpZ25hbHMuCj4+Pj4KPj4+PiBCdXQgc2lu Y2UgdGhlIGNhbGxpbmcgY29kZSBjb3JyZWN0bHkgaGFuZGxlcyB0aGlzIGFscmVhZHkgeW91IGNh biBqdXN0Cj4+Pj4gZHJvcCB0aGlzIGNoYW5nZSBhcyBmYXIgYXMgSSBjYW4gc2VlLgo+Pj4+Cj4+ PiBJIGFncmVlIHRoYXQgd2Ugc2hvdWxkIHJldHVybiAtRVJFU1RBUlRTWVMgdG8gdXBwZXIgbGF5 ZXIgdG8gaGFuZGxlIHNpZ25hbHMuCj4+Pgo+Pj4gQnV0IEkgZG8gbm90IGZpbmQgdXBwZXIgbGF5 ZXJzIGhhbmRsZSAtRVJFU1RBUlRTWVMgaW4gdGhlIGVudGlyZSBjYWxsaW5nCj4+PiBwYXRoLCBr c3lzX2lvY3RsIC0+IGRvX3Zmc19pb2N0bCAtPiBhbWRncHVfZHJtX2lvY3RsIC0+IGRybS0+aW9j dGwgLT4KPj4+IGRybV9pb2N0bF9rZXJuZWwgLT4gYW1kZ3B1X2NzX2lvY3RsLiBUaGUgZXJyb3Ig Y29kZSByZXR1cm5zIHRvCj4+PiBhcHBsaWNhdGlvbi4gSSBjb25maXJtIGl0LCBsaWJkcm0gdXNl cnB0ciB0ZXN0IGFwcGxpY2F0aW9uIGNhbGxpbmcKPj4+IGFtZGdwdV9jc19pb2N0bCByZXR1cm4g Y29kZSBpcyAtNTEyLCB3aGljaCBpcyAtRVJFU1RBUlRTWVMuCj4+Pgo+Pj4gU28gYXBwbGljYXRp b24gc2hvdWxkIGhhbmRsZSAtRVJFU1RBUlRTWVMgdG8gcmVzdGFydCB0aGUgaW9jdGwsIGJ1dAo+ Pj4gbGliZHJtIHVzZXJwdHIgdGVzdCBhcHBsaWNhdGlvbiBkb2Vzbid0IGhhbmRsZSB0aGlzLiBU aGlzIGNhdXNlcyB0aGUKPj4+IHRlc3QgZmFpbGVkLgo+PiBUaGlzIGlzIGEgYnVnIGluIHRoZSB0 ZXN0IGNhc2VzIHRoZW4uCj4+Cj4+IC1FUkVTVEFSVFNZUyBjYW4gaGFwcGVuIGF0IGFueSB0aW1l IGR1cmluZyBpbnRlcnJ1cHRpYmxlIHdhaXRpbmcgYW5kIGl0Cj4+IGlzIG1hbmRhdG9yeSBmb3Ig dGhlIHVwcGVyIGxheWVyIHRvIGhhbmRsZSBpdCBjb3JyZWN0bHkuCj4+Cj4gLUVSRVNUQVJUU1lT IGNhbiBiZSByZXR1cm5lZCBvbmx5IHdoZW4gc2lnbmFsIGlzIHBlbmRpbmcsIHNpZ25hbCBoYW5k bGVyCj4gd2lsbCB0cmFuc2xhdGUgRVJFU1RBUlRTWVMgdG8gRUlOVFIsIGRybUlvY3RsIGluIGxp YmRybSBkb2VzIGhhbmRsZQo+IEVJTlRSIGFuZCByZXN0YXJ0IHRoZSBpb2N0bC4gVGhlIHRlc3Qg Y2FzZXMgYXJlIG9rLgoKSW50ZXJlc3RpbmcsIEkgdGhvdWdodCB0aGF0IHRoaXMgd2FzIGhhbmRs ZWQgdW5jb25kaXRpb25hbGx5IGlmIGEgc2lnbmFsIAppcyBwZW5kaW5nIG9yIG5vdC4gQnV0IHRo YXQgY291bGQgYXMgd2VsbCBiZSBhcmNoaXRlY3R1cmUgc3BlY2lmaWMuCgo+IERyaXZlciBmYWls IHBhdGggc2hvdWxkIG5vdCByZXR1cm4gRVJFU1RBUlRTWVMgdG8gdXNlciBzcGFjZS4gVGhlIG5l dwo+IHBhdGNoLCBJIGNoYW5nZSBhbWRncHVfY3Nfc3VibWl0IHRvIHJldHVybiAtRUFHQUlOIGlm IHVzZXJwdHIgaXMKPiB1cGRhdGVkLCBhbmQgYW1kZ3B1X2NzX2lvY3RsIHJlZG8gdGhlIGlvY3Rs IG9ubHkgaWYgZXJyb3IgY29kZSBpcwo+IC1FQUdBSU4uIEVSRVNUQVJUU1lTIGVycm9yIGNvZGUg cmV0dXJucyB0byB1c2VyIHNwYWNlIGZvciBzaWduYWwgaGFuZGxlCj4gYXMgYmVmb3JlLgoKR29v ZCBpZGVhLCB0aGF0IGlzIHByb2JhYmx5IGNsZWFuZXIuIEVHQUlOIGFuZCBFSU5UUiBzaG91bGQg aGF2ZSB0aGUgCnNhbWUgZWZmZWN0IGluIGRybUlvY3RsIElJUkMuCgo+Pj4gQmVsb3cgYXJlIGRl dGFpbHMgb2YgdXNlcnB0ciBwYXRoIGRpZmZlcmVuY2UuIEZvciB0aGUgcHJldmlvdXMgcGF0aCwK Pj4+IGxpYmRybSB0ZXN0IGFsd2F5cyBnb2VzIHRvIHN0ZXAgMiwgc3RlcCAzIG5ldmVyIHRyaWdn ZXIuIFNvIGl0IG5ldmVyCj4+PiByZXR1cm4gLUVSRVNUQVJUU1lTLCBidXQgaW4gdGhlb3J5LCB0 aGlzIGNvdWxkIGhhcHBlbi4KPj4+Cj4+PiBGb3IgSE1NIHBhdGgsIHRoZSB0ZXN0IGFsd2F5cyBn b2VzIHRvIHN0ZXAgMywgd2UgaGF2ZSB0byBoYW5kbGUgdGhpcwo+Pj4gY2FzZSBpbnNpZGUgYW1k Z3B1X2NzX2lvY3RsLiBNYXliZSBJIGNhbiBjaGFuZ2UgYW1kZ3B1X2NzX3N1Ym1pdCB0bwo+Pj4g cmV0dXJuIC1FQlVTWSwgdGhlbiByZXN0YXJ0IHRoZSBpb2N0bCBpbnNpZGUgYW1kZ3B1X2NzX2lv Y3RsLiBJIHdpbGwKPj4+IHN1Ym1pdCBuZXcgcGF0Y2guCj4+IENsZWFybHkgYSBOQUssIHRoaXMg d29uJ3Qgd29yayBjb3JyZWN0bHkuCj4+Cj4gSSBkb24ndCB1bmRlcnN0YW5kIHlvdXIgY29uY2Vy biwgbWF5IHlvdSBleHBsYWluIHRoZSByZWFzb24/CgpXaGVuIHNvbWUgdW5kZXJseWluZyBjb2Rl IHJldHVybnMgRVJFU1RBUlRTWVMgd2UgKk1VU1QqIGZvcndhcmQgdGhhdCB0byAKdGhlIHVwcGVy IGxheWVyLgoKSGFuZGxpbmcgaXQgaW4gYSBsb29wIG9yIHJlcGxhY2luZyBpdCBtYW51YWxseSB3 aXRoIEVJTlRSIG9yIEVHQUlOIHdpbGwgCmJyZWFrIHNpZ25hbCBoYW5kbGluZy4KClRoaXMgaXMg c3VnZ2VzdGVkIHF1aXRlIG9mdGVuLCBidXQgY2FuIGVuZCB1cCBpbiBhbiBlbmRsZXNzIGxvb3Ag aW5zaWRlIAp0aGUga2VybmVsIHdoaWNoIGlzIHF1aXRlIHVnbHkuCgpSZWdhcmRzLApDaHJpc3Rp YW4uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1n ZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=