From: john.levon@sun.com
Subject: [PATCH] Fix libfsimage compile
Date: Thu, 27 Mar 2008 09:57:19 -0700
Message-ID: <944c00f6745eca2bab8d.1206637039@hatchback>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

# HG changeset patch
# User john.levon@sun.com
# Date 1206637038 25200
# Node ID 944c00f6745eca2bab8d56062d6bffb09155c133
# Parent  c8d200eccd65a7be1696a7e91187190cfbeab254
Fix libfsimage compile

Shell portability fixes.

Signed-off-by: John Levon <john.levon@sun.com>

diff --git a/tools/libfsimage/Makefile b/tools/libfsimage/Makefile
--- a/tools/libfsimage/Makefile
+++ b/tools/libfsimage/Makefile
@@ -2,7 +2,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 include $(XEN_ROOT)/tools/Rules.mk
 
 SUBDIRS-y = common ufs reiserfs iso9660 fat zfs
-SUBDIRS-y += $(shell $(SHELL) env CC="$(CC)" ./check-libext2fs)
+SUBDIRS-y += $(shell env CC="$(CC)" ./check-libext2fs)
 
 .PHONY: all clean install
 all clean install: %: subdirs-%
diff --git a/tools/libfsimage/check-libext2fs b/tools/libfsimage/check-libext2fs
--- a/tools/libfsimage/check-libext2fs
+++ b/tools/libfsimage/check-libext2fs
@@ -9,7 +9,7 @@ int main()
 }
 EOF
 
-if test -z ${CC}; then CC="gcc"; fi
+if test -z "${CC}"; then CC="gcc"; fi
 ${CC} -o ext2-test ext2-test.c -lext2fs >/dev/null 2>&1
 
 if [ $? = 0 ]; then