From: Boris Derzhavets Subject: Re: [PATCH] fix stubdom memory corruption Date: Tue, 14 Apr 2009 05:28:29 -0700 (PDT) Message-ID: <945221.68296.qm@web56103.mail.re3.yahoo.com> References: <49E456F3.2010009@eu.citrix.com> Reply-To: bderzhavets@yahoo.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0688174923==" Return-path: In-Reply-To: <49E456F3.2010009@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============0688174923== Content-Type: multipart/alternative; boundary="0-1816325919-1239712109=:68296" --0-1816325919-1239712109=:68296 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable This one and vl.c patch have been applied. stubdom has been rebuilt and reinstalled. No improvement. Name=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ID=A0=A0 Mem VCPUs=A0=A0= =A0=A0=A0 State=A0=A0 Time(s) Domain-0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 0=A0 7019=A0=A0=A0=A0 2=A0=A0=A0= =A0 r-----=A0=A0=A0 633.9 RHELhvm=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 1=A0 1024=A0=A0=A0=A0 1=A0=A0=A0= =A0 ------=A0=A0=A0=A0=A0 0.0 root@ServerXen331:/etc/xen# netstat -a|grep 590 tcp=A0=A0=A0=A0=A0=A0=A0 0=A0=A0=A0=A0=A0 0 *:5901=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0 *:*=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 LISTEN=A0=A0=A0=A0=20 Boris --- On Tue, 4/14/09, Stefano Stabellini = wrote: From: Stefano Stabellini Subject: [Xen-devel] [PATCH] fix stubdom memory corruption To: "xen-devel" Date: Tuesday, April 14, 2009, 5:27 AM Hi all, this patch fixes a memory corruption in blkfront that happens every time we pass a sector aligned buffer (instead of a page aligned buffer) to blkfront_aio. To trigger the COW we have to write at least a byte to each page of the buffer, but we must be careful not to overwrite useful content. Signed-off-by: Stefano Stabellini diff -r dbc4014882d0 extras/mini-os/blkfront.c --- a/extras/mini-os/blkfront.c=09Wed Apr 01 08:36:21 2009 +0100 +++ b/extras/mini-os/blkfront.c=09Tue Apr 14 10:18:30 2009 +0100 @@ -317,19 +317,21 @@ req->sector_number =3D aiocbp->aio_offset / dev->info.sector_size; =20 for (j =3D 0; j < n; j++) { + req->seg[j].first_sect =3D 0; + req->seg[j].last_sect =3D PAGE_SIZE / dev->info.sector_size - 1; + } + req->seg[0].first_sect =3D ((uintptr_t)aiocbp->aio_buf & ~PAGE_MASK) / dev->info.sector_size; + req->seg[n-1].last_sect =3D (((uintptr_t)aiocbp->aio_buf + aiocbp->aio_nbytes - 1) & ~PAGE_MASK) / dev->info.sector_size; + for (j =3D 0; j < n; j++) { =09uintptr_t data =3D start + j * PAGE_SIZE; if (!write) { /* Trigger CoW if needed */ - *(char*)data =3D 0; + *(char*)(data + (req->seg[j].first_sect << 9)) =3D 0; barrier(); } =09aiocbp->gref[j] =3D req->seg[j].gref =3D gnttab_grant_access(dev->dom, virtual_to_mfn(data), write); -=09req->seg[j].first_sect =3D 0; -=09req->seg[j].last_sect =3D PAGE_SIZE / dev->info.sector_size - 1; } - req->seg[0].first_sect =3D ((uintptr_t)aiocbp->aio_buf & ~PAGE_MASK) / dev->info.sector_size; - req->seg[n-1].last_sect =3D (((uintptr_t)aiocbp->aio_buf + aiocbp->aio_nbytes - 1) & ~PAGE_MASK) / dev->info.sector_size; =20 dev->ring.req_prod_pvt =3D i + 1; =20 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel =0A=0A=0A --0-1816325919-1239712109=:68296 Content-Type: text/html; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable
This one and vl.c patch have been applied.stubdom has been rebuilt and reinstalled.
No improvement.
Name =             &nb= sp;            =             &nb= sp; ID   Mem VCPUs      State  = ; Time(s)
Domain-0         =             &nb= sp;            =    0  7019     2    = r-----    633.9
RHELhvm         &nbs= p;            &= nbsp;           &nbs= p;  1  1024     1     ---= ---      0.0
root@ServerXen331:/etc/xen# netsta= t -a|grep 590
tcp        0  = ;    0 *:5901        = ;          *:*  &nbs= p;            &= nbsp;     LISTEN    

Boris<= br>

--- On Tue, 4/14/09, Stefano Stabellini <stefano.stabel= lini@eu.citrix.com> wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>Subject: [Xen-devel] [PATCH] fix stubdom memory corruption
To: "xen-dev= el" <xen-devel@lists.xensource.com>
Date: Tuesday, April 14, 2009,= 5:27 AM

Hi all,
this patch fixes a memory corruption in blk= front that happens every time
we pass a sector aligned buffer (instead o= f a page aligned buffer) to
blkfront_aio.
To trigger the COW we have = to write at least a byte to each page of the
buffer, but we must be care= ful not to overwrite useful content.

Signed-off-by: Stefano Stabelli= ni <stefano.stabellini@eu.citrix.com>

diff -r dbc4014882d0 ext= ras/mini-os/blkfront.c
--- a/extras/mini-os/blkfront.c=09Wed Apr 01 08:3= 6:21 2009 +0100
+++ b/extras/mini-os/blkfront.c=09Tue Apr 14 10:18:30 20= 09 +0100
@@ -317,19 +317,21 @@
req->sector_number =3D aiocbp-= >aio_offset / dev->info.sector_size;

for (j =3D 0; j <= ; n; j++) {
+ req->seg[j].first_sect =3D 0;
+ req->= ;seg[j].last_sect =3D PAGE_SIZE / dev->info.sector_size - 1;
+ }+ req->seg[0].first_sect =3D ((uintptr_t)aiocbp->aio_buf &~PAGE_MASK) / dev->info.sector_size;
+ req->seg[n-1].last_sec= t =3D (((uintptr_t)aiocbp->aio_buf +
aiocbp->aio_nbytes - 1) &= ~PAGE_MASK) / dev->info.sector_size;
+ for (j =3D 0; j < n; j+= +) {
=09uintptr_t data =3D start + j * PAGE_SIZE;
if (!writ= e) {
/* Trigger CoW if needed */
- *(char*)da= ta =3D 0;
+ *(char*)(data + (req->seg[j].first_sect <&l= t; 9)) =3D 0;
barrier();
}
=09aiocbp->gr= ef[j] =3D req->seg[j].gref =3D
gnttab_grant_access(dev-&= gt;dom, virtual_to_mfn(data), write);
-=09req->seg[j].first_sect =3D = 0;
-=09req->seg[j].last_sect =3D PAGE_SIZE / dev->info.sector_size= - 1;
}
- =20 req->seg[0].first_sect =3D ((uintptr_t)aiocbp->aio_buf &
~PAG= E_MASK) / dev->info.sector_size;
- req->seg[n-1].last_sect =3D = (((uintptr_t)aiocbp->aio_buf +
aiocbp->aio_nbytes - 1) & ~PAGE= _MASK) / dev->info.sector_size;

dev->ring.req_prod_pvt = =3D i + 1;


_______________________________________________
X= en-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xens= ource.com/xen-devel

=0A=0A=0A= =0A --0-1816325919-1239712109=:68296-- --===============0688174923== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0688174923==--