From: "flichtenheld (Code Review)" Date: Sat, 4 Apr 2026 18:56:25 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <945803bb833575e79c75471c1708678a411f1da7-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="pJ0ba2jDujs="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --pJ0ba2jDujs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1609?usp=3Demail to review the following change. Change subject: mtcp: Remove noop statement in multi_tcp_process_outgoing_l= ink_ready ...................................................................... mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready Assigning to a parameter here has no effect. I can see no obvious alternative statement that might have been intended. Found by cppcheck. Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9 Signed-off-by: Frank Lichtenheld --- M src/openvpn/mtcp.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/09/1609/1 diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index 2eab7b7..7651b4d 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -155,10 +155,6 @@ ASSERT(mi =3D=3D item.instance); mi->context.c2.to_link =3D item.buffer->buf; ret =3D multi_process_outgoing_link_dowork(m, mi, mpp_flags); - if (!ret) - { - mi =3D NULL; - } mbuf_free_buf(item.buffer); } return ret; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1609?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9 Gerrit-Change-Number: 1609 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --pJ0ba2jDujs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

mtcp: Remove noop statement in multi_tcp_pr=
ocess_outgoing_link_ready

Assigning to a parameter here has no effec= t. I can see no
obvious alternative statement that might have been inten= ded.

Found by cppcheck.

Change-Id: I04a01cf536ee6d48d54ba623d= da460c4a98859f9
Signed-off-by: Frank Lichtenheld <frank@...2641...>= ;
---
M src/openvpn/mtcp.c
1 file changed, 0 insertions(+), 4 dele= tions(-)

git pull ssh://gerrit.openvpn.net:29418=
/openvpn refs/changes/09/1609/1
diff --git a/src/openvpn/mtcp.c b/s=
rc/openvpn/mtcp.c
index 2eab7b7..7651b4d 100644
<= span>--- a/src/openvpn/mtcp.c
+++ b/src/openvpn/mtcp.c
@@ -155,10 +155,6 @@
ASSERT(mi =3D=3D = item.instance);
mi->context.c2.to_link =3D item= .buffer->buf;
ret =3D multi_process_outgoing_li= nk_dowork(m, mi, mpp_flags);
- if (!ret)
- = mi =3D NULL;
- = }
mbuf_free_buf(item.buffer);
= }
return ret;

T= o view, visit change 1609. To unsubscribe, or for help writing mail filters, vi= sit settings= .

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04a01cf536ee6d48d54ba623dda= 460c4a98859f9
Gerrit-Change-Number: 1609
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --pJ0ba2jDujs=--