From: "flichtenheld (Code Review)" Date: Wed, 1 Apr 2026 15:32:48 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <9468288ce4031926acc7dbfad47ce31d430afb8b-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="xmXDasIBDJQ="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --xmXDasIBDJQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerr= it.openvpn.net/c/openvpn/+/1587?usp=3Demail ) Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certifica= te usage ...................................................................... Patch Set 4: Code-Review-1 (3 comments) File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1587/comment/261d53a9_1d432fb9?usp=3D= email : PS4, Line 619: * Note that we do not check for netscape certificat= e type here but rather This line of the comment appears to describe the check above? http://gerrit.openvpn.net/c/openvpn/+/1587/comment/de76a3de_26cc4a05?usp=3D= email : PS4, Line 620: * check for a gneral SSL/TLS client purpose. We do = not know how long nscert general http://gerrit.openvpn.net/c/openvpn/+/1587/comment/88061c4b_a2679e31?usp=3D= email : PS4, Line 621: * attributes are accepted by TLS library in the fut= ure. Currently OpenSSL 4.0 libraries -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2 Gerrit-Change-Number: 1587 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Wed, 01 Apr 2026 15:32:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --xmXDasIBDJQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

Patch set 4:Code-Review -1=

V= iew Change

3 comments:

  • File src/openvpn/ssl_verify_op= enssl.c:

    • Patch Set #4, Line 619: * Note that we do not check for netscape certificate type here= but rather

      This line of the comment appears to describe the che= ck above?

    • Patch Set #4, Line 620: * check for a gneral SSL/= TLS client purpose. We do not know how long nscert

      general

    • Patch Set #4, Line 621: * attributes are accepted by TLS library= in the future. Currently OpenSSL 4.0

      libraries

    <= /li>

To view, visit change 1587. To unsubscribe, or for help writing mai= l filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca0= 7d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 15:32:48= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --xmXDasIBDJQ=--