Received: from eggs.gnu.org ([209.51.188.92]:58048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gr1En-000057-Ax for qemu-devel@nongnu.org; Tue, 05 Feb 2019 08:58:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gr1El-0000t8-AO for qemu-devel@nongnu.org; Tue, 05 Feb 2019 08:58:09 -0500 References: <20190129175403.18017-1-philmd@redhat.com> <20190129175403.18017-10-philmd@redhat.com> From: Brad Smith Message-ID: <94f74717-0bab-ea0a-e7cc-239a1b1136bf@comstyle.com> Date: Tue, 5 Feb 2019 08:57:26 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Peter Maydell , Gerd Hoffmann , "Daniel P. Berrange" Cc: QEMU Developers , Stefan Hajnoczi , Qemu-block , Igor Mammedov , Paolo Bonzini , Eric Blake , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Kevin Wolf , Max Reitz , Markus Armbruster , Fam Zheng , "Michael S. Tsirkin" , Kamil Rytarowski If someone could point me in the right direction as to how the image is=20 created I could look at coming up with something newer. I would prefer that over=20 some of the workarounds I've seen to date. On 2/5/2019 8:42 AM, Philippe Mathieu-Daud=C3=A9 wrote: > Hi Peter, > > On 2/5/19 2:20 PM, Peter Maydell wrote: >> On Tue, 29 Jan 2019 at 17:57, Philippe Mathieu-Daud=C3=A9 wrote: >>> Various iotests scripts (run via 'make check-block') use bash >>> specific extentions. OpenBSD comes with the Korn shell as default. >>> Install bash to be able to run those tests. >>> >>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >>> --- >>> tests/vm/openbsd | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/tests/vm/openbsd b/tests/vm/openbsd >>> index 6263c8956b..e9c2a3f2c8 100755 >>> --- a/tests/vm/openbsd >>> +++ b/tests/vm/openbsd >>> @@ -45,6 +45,8 @@ class OpenBSDVM(basevm.BaseVM): >>> self.wait_ssh() >>> sys.stderr.write("Disabling W^X on the build partition...\n= ") >>> self.ssh_root_check("sed -E -i 's_(/tmp\ ffs)\ ([^\ ]*)_\\1= \\2,wxallowed_' /etc/fstab") >>> + sys.stderr.write("Installing bash...\n") >>> + self.ssh_root_check("PKG_PATH=3Dhttps://ftp.openbsd.org/pub/= OpenBSD/6.1/packages/amd64 pkg_add bash") >>> self.ssh_root("shutdown -p now") >>> self.wait() >>> >> Wouldn't it make more sense to just update the image to include >> the necessary package, the same way we do with all QEMU's >> other build dependencies ? > Instead of updating the image, Daniel asked if we could upgrade this > image to a more recent release (to remove SDL1), but IIRC the outcome > was there is no manpower for that. Meanwhile, this kludge seems the > simplest way. > BTW This command is run once at image creation.