From: Pavel Fedin Subject: [PATCH] small smbfs bugfix Date: Fri, 26 Jan 2007 09:51:23 +0300 Message-ID: <9510655228.20070126095123@rambler.ru> Reply-To: Pavel Fedin Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------1072D16B3D525787" Cc: viro@zeniv.linux.org.uk To: linux-fsdevel@vger.kernel.org Return-path: Received: from gw2.leta.ru ([88.210.57.116]:33430 "EHLO gw2.leta.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030759AbXAZHNp (ORCPT ); Fri, 26 Jan 2007 02:13:45 -0500 Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org ------------1072D16B3D525787 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hello! This small patch fixes a problem with smbfs in 2.6.19.2 kernel. Should also apply to other kernels. The problem is that smbfs doesn't understand "user" and "noexec" options. This makes it impossible to include into /etc/fstab lines like: /pc2/myshare /mnt/smb/pc2/myshare smbfs user,noauto 0 0 Smbmount expands "user,noauto" to "user,noauto,noexec" plus something else, don't remember exactly what. In the result such an entry simply can't be mounted because smbfs fails due to unknown options. This patch makes smbfs silently ignoring all unknown options instead of producing an error. Also i would suggest to introduce this behavor to all other filesystems. This would greatly improve autofs usability. Imagine a situation: i have a ZIP drive and i'd like to be able to use ext2, ext3 and vfat-formatted cartridges. Also i'm russian user so i use NLS feature for names translation. In the fstab i would write: /dev/hdd /mnt/zip ext2,ext3,vfat user,noauto,iocharset=koi8-r,codepage=866 0 0 But in this case ext2 and ext3 wouldn't work at all since they would fail due to unknown "iocharset" and "codepage" options. -- Best regards, Pavel mailto:sonic_amiga@rambler.ru ------------1072D16B3D525787 Content-Type: application/octet-stream; name="smbfs-fix-2.6.19.2.diff" Content-transfer-encoding: base64 Content-Disposition: attachment; filename="smbfs-fix-2.6.19.2.diff" LS0tIGxpbnV4LTIuNi4xOS4yL2ZzL3NtYmZzL2lub2RlLmMub3JpZwkyMDA3LTAxLTEwIDIy OjEwOjM3LjAwMDAwMDAwMCArMDMwMAorKysgbGludXgtMi42LjE5LjIvZnMvc21iZnMvaW5v ZGUuYwkyMDA3LTAxLTIzIDIwOjMyOjU4LjAwMDAwMDAwMCArMDMwMApAQCAtNDA1LDEwICs0 MDUsNiBAQAogCQljYXNlICd0JzoKIAkJCW1udC0+dHRsID0gdmFsdWU7CiAJCQlicmVhazsK LQkJZGVmYXVsdDoKLQkJCXByaW50ayAoInNtYmZzOiBVbnJlY29nbml6ZWQgbW91bnQgb3B0 aW9uICVzXG4iLAotCQkJCW9wdG9wdCk7Ci0JCQlyZXR1cm4gLTE7CiAJCX0KIAl9CiAJbW50 LT5mbGFncyA9IGZsYWdzOwo= ------------1072D16B3D525787--