From: Neil Armstrong Subject: Re: [PATCH 1/5] drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a Date: Wed, 5 Jun 2019 14:59:22 +0200 Message-ID: <956ecdbd-2ea3-6dc9-d2fa-dbba797dddc0@baylibre.com> References: <20190520133753.23871-1-narmstrong@baylibre.com> <20190520133753.23871-2-narmstrong@baylibre.com> <020c82bc-15fd-6e23-a093-62abfa9b466d@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <020c82bc-15fd-6e23-a093-62abfa9b466d@samsung.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Andrzej Hajda , Laurent.pinchart@ideasonboard.com Cc: jonas@kwiboo.se, hverkuil@xs4all.nl, dri-devel@lists.freedesktop.org, jernej.skrabec@siol.net, heiko@sntech.de, maxime.ripard@bootlin.com, hjc@rock-chips.com, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On 22/05/2019 08:07, Andrzej Hajda wrote: > On 20.05.2019 15:37, Neil Armstrong wrote: >> Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support >> for these modes in the connector if the platform supports them. >> We limit these modes to DW-HDMI IP version >= 0x200a which >> are designed to support HDMI2.0 display modes. >> >> Signed-off-by: Neil Armstrong >> Tested-by: Heiko Stuebner >> --- >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 ++++++ >> include/drm/bridge/dw_hdmi.h | 1 + >> 2 files changed, 7 insertions(+) >> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> index ab7968c8f6a2..b50c49caf7ae 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> @@ -2629,6 +2629,12 @@ __dw_hdmi_probe(struct platform_device *pdev, >> if (hdmi->phy.ops->setup_hpd) >> hdmi->phy.ops->setup_hpd(hdmi, hdmi->phy.data); >> >> + if (hdmi->version >= 0x200a) >> + hdmi->connector.ycbcr_420_allowed = >> + hdmi->plat_data->ycbcr_420_allowed; >> + else >> + hdmi->connector.ycbcr_420_allowed = false; >> + > > > I suspect else clause can be dropped. You are right, thanks for the review. Do you have comments on the patches 2, 3 & 4 of serie ? Thanks, Neil > > Beside this: > > Reviewed-by: Andrzej Hajda > >  -- > Regards > Andrzej > > >> memset(&pdevinfo, 0, sizeof(pdevinfo)); >> pdevinfo.parent = dev; >> pdevinfo.id = PLATFORM_DEVID_AUTO; >> diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h >> index 66e70770cce5..0f0e82638fbe 100644 >> --- a/include/drm/bridge/dw_hdmi.h >> +++ b/include/drm/bridge/dw_hdmi.h >> @@ -130,6 +130,7 @@ struct dw_hdmi_plat_data { >> const struct drm_display_mode *mode); >> unsigned long input_bus_format; >> unsigned long input_bus_encoding; >> + bool ycbcr_420_allowed; >> >> /* Vendor PHY support */ >> const struct dw_hdmi_phy_ops *phy_ops; > >