From: Colin Xu Subject: Re: [PATCH 1/2] drm/i915: Update virtual PCH in single function Date: Tue, 29 May 2018 00:31:55 +0000 (UTC) Message-ID: <957312d7-4630-51ec-33fa-825488fec708@intel.com> References: <20180529045038.31397-1-colin.xu@intel.com> <20180529045038.31397-2-colin.xu@intel.com> <87tvqsi0im.fsf@intel.com> <87r2lwhzzv.fsf@intel.com> <87in77j3qe.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C2CE89807 for ; Tue, 29 May 2018 00:34:00 +0000 (UTC) Date: Wed, 30 May 2018 08:36:39 +0800 In-Reply-To: <87in77j3qe.fsf@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDUvMjgvMjAxOCAwOTo0MiBQTSwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gT24gTW9uLCAyOCBN YXkgMjAxOCwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4gd3JvdGU6Cj4+IE9u IE1vbiwgMjggTWF5IDIwMTgsIEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+IHdy b3RlOgo+Pj4gT24gVHVlLCAyOSBNYXkgMjAxOCwgY29saW4ueHVAaW50ZWwuY29tIHdyb3RlOgo+ Pj4+IEZyb206IENvbGluIFh1IDxjb2xpbi54dUBpbnRlbC5jb20+Cj4+Pj4KPj4+PiBUaGUgZXhp c3Rpbmcgd2F5IHRvIHVwZGF0ZSB2aXJ0dWFsIFBDSCB3aWxsIHJldHVybiB3cm9uZyBQQ0ggdHlw ZQo+Pj4+IGluIGNhc2UgdGhlIGhvc3QgZG9lc24ndCBoYXZlIFBDSDoKPj4+PiAgICAtIGludGVs X3ZpcnRfZGV0ZWN0X3BjaCByZXR1cm5zIGd1ZXNzZWQgUENIIGlkIDAKPj4+PiAgICAtIGlkIDAg bWFwcyB0byBQQ0hfTk9QLiA+PiBzaG91bGQgYmUgUENIX05PTkUuCj4+Pj4gU2luY2UgUENIX05P TkUgYW5kIFBDSF9OT1AgYXJlIGRpZmZlcmVudCB0eXBlcywgbWl4aW5nIHRoZW0gdXAKPj4+PiB3 aWxsIGJyZWFrIHZidCBpbml0aWFsaXphdGlvbiBsb2dpYy4KPj4+Pgo+Pj4+IEluIGFkZGl0aW9u LCB0byBhZGQgbmV3IG5vbmUvbm9wIFBDSCBvdmVycmlkZSBmb3IgYSBzcGVjaWZpYwo+Pj4+IHBs YXRmb3JtLCBicmFuY2hpbmcgbmVlZCB0byBiZSBhZGRlZCB0byBpbnRlbF92aXJ0X2RldGVjdF9w Y2goKSwKPj4+PiBpbnRlbF9wY2hfdHlwZSgpIGFuZCB0aGUgY2FsbGVyIHNpbmNlIG5vbmUvbm9w IFBDSCBpcyBub3QgYWx3YXlzCj4+Pj4gbWFwcGluZyB0byB0aGUgc2FtZSBwcmVkZWZpbmVkIFBD SCBpZC4KPj4+Pgo+Pj4+IFRoaXMgcGF0Y2ggbWVyZ2VzIHRoZSB2aXJ0dWFsIFBDSCB1cGRhdGUv c2FuaXR5IGNoZWNrIGxvZ2ljIGludG8KPj4+PiBzaW5nbGUgZnVuY3Rpb24gaW50ZWxfdmlydF91 cGRhdGVfcGNoKCksIHdoaWNoIHN0aWxsIGtlZXBzIHVzaW5nCj4+Pj4gZXhpc3RpbmcgaW50ZWxf cGNoX3R5cGUoKSB0byBkbyB0aGUgc2FuaXR5IGNoZWNrLCB3aGlsZSBtYWtpbmcgaXQKPj4+PiBj bGVhbiB0byBvdmVycmlkZSB2aXJ0dWFsIFBDSCBpZCBmb3IgYSBzcGVjaWZpYyBwbGF0Zm9ybSBm b3IgZnV0dXJlCj4+Pj4gcGxhdGZvcm0gZW5hYmxlbWVudC4KPj4+IFBsZWFzZSBrZWVwIHRoZSBh c3NpZ25tZW50IG91dCBvZiBpbnRlbF92aXJ0X3tkZXRlY3QsdXBkYXRlfV9wY2ggbGlrZS4gSQo+ Pj4gdGhpbmsgdGhlIHBhdGNoIGhlcmUgaXMgdW5uZWNlc3NhcmlseSBjb21wbGljYXRlZC4KPj4g VG8gZWxhYm9yYXRlLCBpbnRlbF9wY2hfdHlwZSgpIHNob3VsZCAqYWx3YXlzKiBiZSBhYmxlIHRv IG1hcCBwY2ggaWQgdG8KPj4gcGNoIHR5cGUuIFRoZXJlIHNob3VsZCBub3QgYmUgY29tYmluYXRp b25zIHRoYXQgYXJlbid0IGNvdmVyZWQgYnkKPj4gdGhhdC4gSWYgdGhlIHNhbml0eSBjaGVja3Mg dGhlcmUgbmVlZCB0byBhY2NlcHQgQnJveHRvbiBhcyB3ZWxsLCBwZXJoYXBzCj4+IHBhc3MgYSBw YXJhbWV0ZXIgdG8gaW5kaWNhdGUgdmlydHVhbGl6YXRpb24sIGFuZCBhY2NlcHQgY2VydGFpbiBw Y2ggaWRzCj4+IGZvciBCcm94dG9uIGFzIHdlbGwuCj4+Cj4+IElmIHlvdSdyZSBmYWtpbmcgYSBw Y2ggZm9yIEJyb3h0b24sIEkgZG9uJ3QgdGhpbmsgdGhlcmUncyBhIGNhc2Ugd2hlcmUKPj4gcGNo IGlkIHNob3VsZCBiZSAwIGFuZCBwY2ggdHlwZSBzaG91bGQgYmUgc29tZXRoaW5nIGVsc2UuIEVp dGhlciBib3RoCj4+IGFyZSB6ZXJvLCBvciBib3RoIGFyZSBub24temVyby4KPiAtRU5PQ09GRkVF IGluIHRoZSBtb3JuaW5nLiBJcyB0aGUgZml4IHlvdSdyZSBsb29raW5nIGZvciBzaW1wbHk6CgpZ ZXMgdGhpcyBpcyB0aGUgbW9zdCBzaW1wbHkgd2F5LgpUaGUgcmVhc29uIEkgZGlkbid0IGNyYWZ0 IHRoZSBwYXRjaCBsaWtlIHRoaXMgaW4gdGhlIGJlZ2lubmluZyBpcyB0aGF0CkknbSBub3Qgc3Vy ZSBhZnRlciB5b3VyIHJlZmFjdG9yaW5nIHBhdGNoLCBpZiB0aGUgY2FzZSBleGlzdHMgdGhhdCBw Y2gKaWQgMCBtYXBzIHRvIHR5cGUgZWl0aGVyIG5vcCBvciBub25lLgpBcyB5b3Ugc2FpZCB0aGVy ZSBpcyBubyBzdWNoIGNhc2UsIHRoZSBzaW1wbHkgY2hhbmdlIHNob3VsZCB3b3JrIHdlbGwuCldp bGwgeW91IG1hZGUgdGhlIGNoYW5nZSBzb21ldGltZSBvciBJIG5lZWQgdXBkYXRlIG15IHBhdGNo IHNldD8KLS0gCkJlc3QgUmVnYXJkcywKQ29saW4gWHUKCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5j Cj4gaW5kZXggOWM0NDliOGQ4ZWFiLi5hZTA3ZTM2ZTM2NGMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmMKPiBAQCAtMjg3LDcgKzI4Nyw3IEBAIHN0YXRpYyB2b2lkIGludGVsX2RldGVjdF9w Y2goc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgCQkJCWlmIChXQVJOX09O KHBjaF90eXBlID09IFBDSF9OT05FKSkKPiAgIAkJCQkJcGNoX3R5cGUgPSBQQ0hfTk9QOwo+ICAg CQkJfSBlbHNlIHsKPiAtCQkJCXBjaF90eXBlID0gUENIX05PUDsKPiArCQkJCXBjaF90eXBlID0g UENIX05PTkU7Cj4gICAJCQl9Cj4gICAJCQlkZXZfcHJpdi0+cGNoX3R5cGUgPSBwY2hfdHlwZTsK PiAgIAkJCWRldl9wcml2LT5wY2hfaWQgPSBpZDsKPgo+IC0tLQo+Cj4gQlIsCj4gSmFuaS4KPgo+ Cj4+Cj4+IEJSLAo+PiBKYW5pCj4+Cj4+Cj4+Cj4+Cj4+Cj4+PiBCUiwKPj4+IEphbmkuCj4+Pgo+ Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBYdSA8Y29saW4ueHVAaW50ZWwuY29tPgo+Pj4+ IC0tLQo+Pj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyB8IDU2ICsrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+Pj4+ICAgMSBmaWxlIGNoYW5nZWQsIDMwIGluc2Vy dGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5j Cj4+Pj4gaW5kZXggZmIzOWU0MGMwODQ3Li42MzdiYTg2MTA0YmUgMTAwNjQ0Cj4+Pj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmMKPj4+PiBAQCAtMjA5LDEwICsyMDksMTEgQEAgc3RhdGljIGJvb2wg aW50ZWxfaXNfdmlydF9wY2godW5zaWduZWQgc2hvcnQgaWQsCj4+Pj4gICAJCSBzZGV2aWNlID09 IFBDSV9TVUJERVZJQ0VfSURfUUVNVSkpOwo+Pj4+ICAgfQo+Pj4+ICAgCj4+Pj4gLXN0YXRpYyB1 bnNpZ25lZCBzaG9ydAo+Pj4+IC1pbnRlbF92aXJ0X2RldGVjdF9wY2goY29uc3Qgc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Pj4+ICtzdGF0aWMgdm9pZAo+Pj4+ICtpbnRlbF92 aXJ0X3VwZGF0ZV9wY2goc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Pj4+ICAg ewo+Pj4+ICAgCXVuc2lnbmVkIHNob3J0IGlkID0gMDsKPj4+PiArCWVudW0gaW50ZWxfcGNoIHBj aF90eXBlID0gUENIX05PTkU7Cj4+Pj4gICAKPj4+PiAgIAkvKgo+Pj4+ICAgCSAqIEluIGEgdmly dHVhbGl6ZWQgcGFzc3Rocm91Z2ggZW52aXJvbm1lbnQgd2UgY2FuIGJlIGluIGEKPj4+PiBAQCAt MjIxLDI1ICsyMjIsMzcgQEAgaW50ZWxfdmlydF9kZXRlY3RfcGNoKGNvbnN0IHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4+PiAgIAkgKiBtYWtlIGFuIGVkdWNhdGVkIGd1ZXNz IGFzIHRvIHdoaWNoIFBDSCBpcyByZWFsbHkgdGhlcmUuCj4+Pj4gICAJICovCj4+Pj4gICAKPj4+ PiAtCWlmIChJU19HRU41KGRldl9wcml2KSkKPj4+PiArCWlmIChJU19HRU41KGRldl9wcml2KSkg ewo+Pj4+ICAgCQlpZCA9IElOVEVMX1BDSF9JQlhfREVWSUNFX0lEX1RZUEU7Cj4+Pj4gLQllbHNl IGlmIChJU19HRU42KGRldl9wcml2KSB8fCBJU19JVllCUklER0UoZGV2X3ByaXYpKQo+Pj4+ICsJ CXBjaF90eXBlID0gaW50ZWxfcGNoX3R5cGUoZGV2X3ByaXYsIGlkKTsKPj4+PiArCQlEUk1fREVC VUdfS01TKCJBc3N1bWluZyBJYmV4IFBlYWsgUENIIGlkICUwNHhcbiIsIGlkKTsKPj4+PiArCX0g ZWxzZSBpZiAoSVNfR0VONihkZXZfcHJpdikgfHwgSVNfSVZZQlJJREdFKGRldl9wcml2KSkgewo+ Pj4+ICAgCQlpZCA9IElOVEVMX1BDSF9DUFRfREVWSUNFX0lEX1RZUEU7Cj4+Pj4gLQllbHNlIGlm IChJU19IU1dfVUxUKGRldl9wcml2KSB8fCBJU19CRFdfVUxUKGRldl9wcml2KSkKPj4+PiAtCQlp ZCA9IElOVEVMX1BDSF9MUFRfTFBfREVWSUNFX0lEX1RZUEU7Cj4+Pj4gLQllbHNlIGlmIChJU19I QVNXRUxMKGRldl9wcml2KSB8fCBJU19CUk9BRFdFTEwoZGV2X3ByaXYpKQo+Pj4+IC0JCWlkID0g SU5URUxfUENIX0xQVF9ERVZJQ0VfSURfVFlQRTsKPj4+PiAtCWVsc2UgaWYgKElTX1NLWUxBS0Uo ZGV2X3ByaXYpIHx8IElTX0tBQllMQUtFKGRldl9wcml2KSkKPj4+PiArCQlwY2hfdHlwZSA9IGlu dGVsX3BjaF90eXBlKGRldl9wcml2LCBpZCk7Cj4+Pj4gKwkJRFJNX0RFQlVHX0tNUygiQXNzdW1p bmcgQ291Z2FyUG9pbnQgUENIIGlkICUwNHhcbiIsIGlkKTsKPj4+PiArCX0gZWxzZSBpZiAoSVNf SEFTV0VMTChkZXZfcHJpdikgfHwgSVNfQlJPQURXRUxMKGRldl9wcml2KSkgewo+Pj4+ICsJCWlm IChJU19IU1dfVUxUKGRldl9wcml2KSB8fCBJU19CRFdfVUxUKGRldl9wcml2KSkKPj4+PiArCQkJ aWQgPSBJTlRFTF9QQ0hfTFBUX0xQX0RFVklDRV9JRF9UWVBFOwo+Pj4+ICsJCWVsc2UKPj4+PiAr CQkJaWQgPSBJTlRFTF9QQ0hfTFBUX0RFVklDRV9JRF9UWVBFOwo+Pj4+ICsJCXBjaF90eXBlID0g aW50ZWxfcGNoX3R5cGUoZGV2X3ByaXYsIGlkKTsKPj4+PiArCQlEUk1fREVCVUdfS01TKCJBc3N1 bWluZyBMeW54UG9pbnQgUENIIGlkICUwNHhcbiIsIGlkKTsKPj4+PiArCX0gZWxzZSBpZiAoSVNf U0tZTEFLRShkZXZfcHJpdikgfHwgSVNfS0FCWUxBS0UoZGV2X3ByaXYpKSB7Cj4+Pj4gICAJCWlk ID0gSU5URUxfUENIX1NQVF9ERVZJQ0VfSURfVFlQRTsKPj4+PiAtCWVsc2UgaWYgKElTX0NPRkZF RUxBS0UoZGV2X3ByaXYpIHx8IElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpKQo+Pj4+ICsJCXBjaF90 eXBlID0gaW50ZWxfcGNoX3R5cGUoZGV2X3ByaXYsIGlkKTsKPj4+PiArCQlEUk1fREVCVUdfS01T KCJBc3N1bWluZyBTdW5yaXNlUG9pbnQgUENIIGlkICUwNHhcbiIsIGlkKTsKPj4+PiArCX0gZWxz ZSBpZiAoSVNfQ09GRkVFTEFLRShkZXZfcHJpdikgfHwgSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikp IHsKPj4+PiAgIAkJaWQgPSBJTlRFTF9QQ0hfQ05QX0RFVklDRV9JRF9UWVBFOwo+Pj4+ICsJCXBj aF90eXBlID0gaW50ZWxfcGNoX3R5cGUoZGV2X3ByaXYsIGlkKTsKPj4+PiArCQlEUk1fREVCVUdf S01TKCJBc3N1bWluZyBDYW5ub25Qb2ludCBQQ0ggaWQgJTA0eFxuIiwgaWQpOwo+Pj4+ICsJfSBl bHNlIHsKPj4+PiArCQlpZCA9IDA7Cj4+Pj4gKwkJcGNoX3R5cGUgPSBQQ0hfTk9QOwo+Pj4+ICsJ CURSTV9ERUJVR19LTVMoIkFzc3VtaW5nIE5PUCBQQ0hcbiIpOwo+Pj4+ICsJfQo+Pj4+ICAgCj4+ Pj4gLQlpZiAoaWQpCj4+Pj4gLQkJRFJNX0RFQlVHX0tNUygiQXNzdW1pbmcgUENIIElEICUwNHhc biIsIGlkKTsKPj4+PiAtCWVsc2UKPj4+PiAtCQlEUk1fREVCVUdfS01TKCJBc3N1bWluZyBubyBQ Q0hcbiIpOwo+Pj4+IC0KPj4+PiAtCXJldHVybiBpZDsKPj4+PiArCWRldl9wcml2LT5wY2hfdHlw ZSA9IHBjaF90eXBlOwo+Pj4+ICsJZGV2X3ByaXYtPnBjaF9pZCA9IGlkOwo+Pj4+ICAgfQo+Pj4+ ICAgCj4+Pj4gICBzdGF0aWMgdm9pZCBpbnRlbF9kZXRlY3RfcGNoKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPj4+PiBAQCAtMjgxLDE2ICsyOTQsNyBAQCBzdGF0aWMgdm9pZCBp bnRlbF9kZXRlY3RfcGNoKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4+PiAg IAkJCWJyZWFrOwo+Pj4+ICAgCQl9IGVsc2UgaWYgKGludGVsX2lzX3ZpcnRfcGNoKGlkLCBwY2gt PnN1YnN5c3RlbV92ZW5kb3IsCj4+Pj4gICAJCQkJCSBwY2gtPnN1YnN5c3RlbV9kZXZpY2UpKSB7 Cj4+Pj4gLQkJCWlkID0gaW50ZWxfdmlydF9kZXRlY3RfcGNoKGRldl9wcml2KTsKPj4+PiAtCQkJ aWYgKGlkKSB7Cj4+Pj4gLQkJCQlwY2hfdHlwZSA9IGludGVsX3BjaF90eXBlKGRldl9wcml2LCBp ZCk7Cj4+Pj4gLQkJCQlpZiAoV0FSTl9PTihwY2hfdHlwZSA9PSBQQ0hfTk9ORSkpCj4+Pj4gLQkJ CQkJcGNoX3R5cGUgPSBQQ0hfTk9QOwo+Pj4+IC0JCQl9IGVsc2Ugewo+Pj4+IC0JCQkJcGNoX3R5 cGUgPSBQQ0hfTk9QOwo+Pj4+IC0JCQl9Cj4+Pj4gLQkJCWRldl9wcml2LT5wY2hfdHlwZSA9IHBj aF90eXBlOwo+Pj4+IC0JCQlkZXZfcHJpdi0+cGNoX2lkID0gaWQ7Cj4+Pj4gKwkJCWludGVsX3Zp cnRfdXBkYXRlX3BjaChkZXZfcHJpdik7Cj4+Pj4gICAJCQlicmVhazsKPj4+PiAgIAkJfQo+Pj4+ ICAgCX0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==