From: "flichtenheld (Code Review)"
Date: Thu, 10 Jul 2025 11:14:48 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <95a6650b0344da56768d26d868ad00a9535de68a-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="4USGHu8KTAQ="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Do not compile mbed
key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--4USGHu8KTAQ=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/1081?usp=3Demail )
Change subject: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATE=
RIAL_EXPORT
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/openvpn/ssl_mbedtls.c:
http://gerrit.openvpn.net/c/openvpn/+/1081/comment/7552178f_39f98b2e :
PS1, Line 177: #if HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB && !defined(MBE=
DTLS_SSL_KEYING_MATERIAL_EXPORT)
> Change makes sense, but now every clause of the #if .. #elif .. [=E2=80=
=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1081?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c5fcf0f6f74efd
Gerrit-Change-Number: 1081
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Thu, 10 Jul 2025 11:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--4USGHu8KTAQ=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
Patch set 2:Code-Review +2=
V=
iew Change
1 comment:
Done
To view, vi=
sit chan=
ge 1081. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c=
5fcf0f6f74efd
Gerrit-Change-Number: 1081
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Thu, 10 Jul 2025 11:14:48=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--4USGHu8KTAQ=--