Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E388EC2BBCA for ; Tue, 25 Jun 2024 14:49:34 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.747866.1155376 (Exim 4.92) (envelope-from ) id 1sM7U6-0004SV-DW; Tue, 25 Jun 2024 14:49:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 747866.1155376; Tue, 25 Jun 2024 14:49:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sM7U6-0004SO-AJ; Tue, 25 Jun 2024 14:49:26 +0000 Received: by outflank-mailman (input) for mailman id 747866; Tue, 25 Jun 2024 14:49:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sM7U5-0004SI-3B for xen-devel@lists.xenproject.org; Tue, 25 Jun 2024 14:49:25 +0000 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [2a00:1450:4864:20::232]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c4abc4c-3302-11ef-b4bb-af5377834399; Tue, 25 Jun 2024 16:49:23 +0200 (CEST) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2ec58040f39so32152631fa.2 for ; Tue, 25 Jun 2024 07:49:23 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7068af60b61sm3360514b3a.134.2024.06.25.07.49.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 07:49:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c4abc4c-3302-11ef-b4bb-af5377834399 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719326962; x=1719931762; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Su1fw8OFbAmbG4pvwPw6Bvr3dAWnfrD9VfuzVqzhebU=; b=NGe4OBFfbPCFAJH3xOzAqag1Zt9B2ht50cgg1xZLhKi3zVWg0yW6dHiMDYvItvdu0G /420+oHD9jNGNrDs1tJBfX2ajei6Is4DA43/KBG0L/FvbfujvknW89lJf+pjOBKMpECW j4tKXO3trQN99nYh4h+CCgN9jiSScW8zYTEj0AzQEXKOmhbvqwGkWfai4j3Y8FogKWbt ipI2ekokvDqdnghfA+vnPV0a3ge+SfptTg1USVZu5Zj+hsVJZbndqkpqrNwigfXKpsX0 TQJW4LAIHHsfHy/vhepNRoB8oJnlQBLCpCe7gk9z3GopClMNIOzmgwucBdBcK9Uay64T RXMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719326962; x=1719931762; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Su1fw8OFbAmbG4pvwPw6Bvr3dAWnfrD9VfuzVqzhebU=; b=SKSmPPR2iu0IU/rn44V4I7Cz+nDKaUebLGFe/LSkX6qtOCa7SUHXYFy/3VvtHZry6W ShnEtFBNAhJNYfB8S8qgRH7pCQ06X2tSo2pQRN0axY5LGLzxGAHMKs/yoHgM2L9alggC TChkSPc0kiIUJTGedPuwKI7p76Zp5uXXWwjPNhuRX1Ew8V05vpK/SePQcQFsfjyYocs2 rY7YWDMepUyG85oSCnj/J75LtLXEMBmhDKUI++3KIgowvllz/tc/vkN3DCQgk4WGezmE +W8ianV4AITFFtpb6NF1GN2AeKx/HOT30D32YeZVIq3CfUGqudPLgIaRdvKh3Q5bykpr TzWg== X-Forwarded-Encrypted: i=1; AJvYcCVqXRN0vDoKXYG4O4ljtMXs3bOksv18kilDSm4IzVcTSVq5zCpVv+EFwYIZ4G5TIIynm1YCM1YzAv9VeJ3d/Qi695vrGQWphmVFxeuT+U8= X-Gm-Message-State: AOJu0YyrlaYmBX12o5nUOw54NFbtd79LGNzDgZawMrrUL4+yDoUoZgvh wqfXtvPRf6f9dKSiQlE+g4IPwkDhBJ6IpfPPJKSkFltaaCxFg0+x16SriXRDfQ== X-Google-Smtp-Source: AGHT+IGZ26yCFTOu30zLwaWfoshB6xJx+fnUGmDwpEleyXzJBvLR1gihOB3AliwO6mARCHouq9A1Vg== X-Received: by 2002:a2e:9083:0:b0:2ec:53ad:464 with SMTP id 38308e7fff4ca-2ec594cfa5fmr45957491fa.34.1719326962530; Tue, 25 Jun 2024 07:49:22 -0700 (PDT) Message-ID: <95f64eba-13b9-404a-8318-7a3fc77ea560@suse.com> Date: Tue, 25 Jun 2024 16:49:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 09/10] xen/riscv: introduce ANDN_INSN To: Oleksii Kurochko Cc: Alistair Francis , Bob Eshleman , Connor Davis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25.06.2024 15:51, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/cmpxchg.h > +++ b/xen/arch/riscv/include/asm/cmpxchg.h > @@ -18,6 +18,20 @@ > : "r" (new) \ > : "memory" ); > > +/* > + * Binutils < 2.37 doesn't understand ANDN. If the toolchain is too > +ld, form Same question: Why's 2.37 suddenly of interest? Plus, why would age of the tool chain matter? What you care about is whether you're permitted to use the extension at runtime. Otherwise you could again ... Also something went wrong with line wrapping here. > + * it of a NOT+AND pair > + */ > +#ifdef __riscv_zbb > +#define ANDN_INSN(rd, rs1, rs2) \ > + "andn " rd ", " rs1 ", " rs2 "\n" > +#else > +#define ANDN_INSN(rd, rs1, rs2) \ > + "not " rd ", " rs2 "\n" \ > + "and " rd ", " rs1 ", " rd "\n" ... resort to .insn. Jan