From: Alex Dubov Date: Wed, 5 Aug 2009 20:21:03 -0700 (PDT) Subject: [U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards In-Reply-To: <20090805081614.8FDEA8340728@gemini.denx.de> Message-ID: <963516.31353.qm@web37603.mail.mud.yahoo.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > > > > Just a general observation: if you are not sure that > tlb/law files can be > > safely factored out and most of the ddr.c files are > actually board specific > > overrides (common part being less than 10 lines) why > had you requested me > > to create a common board hierarchy for these STX > boards in the first place? > > I am sure that the tlb/law files can be safely factored > out, but that > does not mean that you can simply use one of the files > and? force? it > upon? the? othe? rboards.? The? > differences? between? the boards must > obviously been taken care? of,? for? > example? by? using? preprocessor > variables? (defined in the board config files) to > describe the (tiny) > differences between the boards. > > I don't understand why you claim the ddr.c files were so > different: > > -> diff board/stxgp3/ddr.c board/stxssa/ddr.c | wc -l > 0 > How exactly I'm related to this particular issue? My ddr.c is different due to different DDR settings overrides. Then, there are plenty of nearly identical ddr.c/tlb.c/law.c files in the tree already (~25). Git will derive any such file from any other, because they are essentially the same. However, the real issue here is whether you prefer a #define sprawl or having a couple of additional short files for each board in question. Until now, as I can see, the second option was preferred.