Message-ID: <96550638-91b8-5f63-ebe1-008895d1c795@...2181...> Date: Mon, 27 Jun 2022 20:50:39 +0200 MIME-Version: 1.0 Content-Language: en-US References: <20220624083809.23487-1-a@...2181...> <20220624083809.23487-20-a@...2181...> From: Antonio Quartulli In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH 19/25] dco-win: implement GetOverlappedResultEx for mingw32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Lev Stipakov , Selva Nair Cc: openvpn-devel , Lev Stipakov Hi, On 27/06/2022 12:30, Lev Stipakov wrote: > Hi, > > The problem this patch solves appeared on mingw-w64 for 32bit version > 6.0.0, which is the latest version of mingw on Windows. When this > patch was written (April 2021), we still used travis/appveyor which > did mingw builds on Windows so back then patch made sense. > > Since we moved to GHa since the last summer and mingw builds are done > on Linux with new enough mingw, this patch could be safely removed. > > I dropped this commit and pushed changes to my fork and GHa is happy: > https://github.com/lstipakov/openvpn/actions/runs/2567640010 > The 'dco' branch has been modified accordingly: * compat patch 19/25 removed; * code now uses GetOverlappedResultEx() directly. Cheers, -- Antonio Quartulli