From: "ordex (Code Review)" Date: Wed, 8 Apr 2026 20:08:56 +0000 In-Reply-To: References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <9661f14875730e95076b117e1c9d019f1db81a85-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="g24XKm1tCJ8="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: networking_sitnl: Make sitnl_parse_rtattr* return void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --g24XKm1tCJ8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change by flichtenheld. ( http://gerrit.o= penvpn.net/c/openvpn/+/1614?usp=3Demail ) Change subject: networking_sitnl: Make sitnl_parse_rtattr* return void ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: indeed, this patch makes sense. sitnl_parse_rtattr is just parsing what it = can, without ever failing. Thanks! -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1614?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Idfe2afd9616e17f0f80a914ff054ae18f0b6972b Gerrit-Change-Number: 1614 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 08 Apr 2026 20:08:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --g24XKm1tCJ8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld, plaisthos.

Patch set 2:Code-Review +2=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #2:

      indeed, thi= s patch makes sense. sitnl_parse_rtattr is just parsing what it can, withou= t ever failing.
      Thanks!

To view, visit change 1614= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idfe2afd9616e17f0f80a914ff05= 4ae18f0b6972b
Gerrit-Change-Number: 1614
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: ordex <antonio@...2726...&= gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 08 Apr 2026 20:08:56= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --g24XKm1tCJ8=--