From: thierry.martinez@inria.fr (Thierry Martinez) Date: Sat, 18 Nov 2017 01:33:53 +0100 (CET) Subject: [Cocci] Compiling with OCaml 4.06 / safe-string In-Reply-To: References: <20171117190307.GA26286@redhat.com> Message-ID: <966666294.17706552.1510965233649.JavaMail.zimbra@inria.fr> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr Hi, Richard and Julia. Richard: > > Obviously I could switch to -unsafe-string, but has anyone fixed this? I just submitted a pull request to the parmap repository: https://github.com/rdicosmo/parmap/pull/64 You should be able to compile Coccinelle by opam-pinning this parmap version. I will integrate it to Coccinelle bundle, but it will take some time because I would like to integrate stdcompat first (because the parmap fix uses bytes and I want to keep compatibility with older OCamls). Thank you for reporting this! Best regards. -- Thierry. ----- Original Message ----- > From: "Julia Lawall" > To: "Richard W.M. Jones" > Cc: cocci at systeme.lip6.fr > Sent: Friday, November 17, 2017 8:40:07 PM > Subject: Re: [Cocci] Compiling with OCaml 4.06 / safe-string > > > > On Fri, 17 Nov 2017, Richard W.M. Jones wrote: > > > I'm trying to compile coccinelle with OCaml 4.06, where the default > > for strings has been switched to -safe-string. > > > > It currently fails to build in the bundled parmap library: > > > > /usr/bin/ocamlc.opt -unsafe -I parmap.1.0-rc7.1 -custom -cclib > > -lparmap_stubs -c parmap.1.0-rc7.1/bytearray.ml -o > > parmap.1.0-rc7.1/bytearray.cmo > > File "parmap.1.0-rc7.1/bytearray.ml", line 38, characters 0-118: > > Warning 3: deprecated: [@@noalloc] should be used instead of "noalloc" > > File "parmap.1.0-rc7.1/bytearray.ml", line 41, characters 0-116: > > Warning 3: deprecated: [@@noalloc] should be used instead of "noalloc" > > File "parmap.1.0-rc7.1/bytearray.ml", line 47, characters 10-23: > > Warning 3: deprecated: String.create > > Use Bytes.create instead. > > File "parmap.1.0-rc7.1/bytearray.ml", line 48, characters 28-29: > > Error: This expression has type bytes but an expression was expected of > > type > > string > > > > I tried fixing this, but the library is doing a bunch of stuff with > > actually overwriting strings, and I'm not clear how safe that is with > > -safe-string. Anyway, a fix isn't trivial. Upstream parmap doesn't > > have a fix that I could see. > > > > Obviously I could switch to -unsafe-string, but has anyone fixed this? > > Perhaps check with the Parmap people. > > julia > _______________________________________________ > Cocci mailing list > Cocci at systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci >