Received: from eggs.gnu.org ([2001:4830:134:3::10]:56981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAoTz-00066b-3o for qemu-devel@nongnu.org; Tue, 04 Feb 2014 17:28:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAoTt-0004YA-Cx for qemu-devel@nongnu.org; Tue, 04 Feb 2014 17:28:43 -0500 Received: from vserver.eikelenboom.it ([84.200.39.61]:32832 helo=smtp.eikelenboom.it) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAoTt-0004Xo-7Y for qemu-devel@nongnu.org; Tue, 04 Feb 2014 17:28:37 -0500 Date: Tue, 4 Feb 2014 23:28:31 +0100 From: Sander Eikelenboom Message-ID: <969962337.20140204232831@eikelenboom.it> In-Reply-To: <52F161C6.4070603@redhat.com> References: <1391549456-465-1-git-send-email-mst@redhat.com> <52F161C6.4070603@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Stefano Stabellini , qemu-devel@nongnu.org, Anthony Liguori , "Michael S. Tsirkin" Tuesday, February 4, 2014, 10:55:18 PM, you wrote: > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: >> xenfv has no fwcfg and so does not load acpi from QEMU. >> as such new acpi features don't work. >> >> Reported-by: Sander Eikelenboom >> Signed-off-by: Michael S. Tsirkin >> --- >> >> Sander, could you pleas econfirm this works for you? Yes this works for me (still on top of the debug patches + pull of the branch igor mentoined), but without -global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off: No fw cfg. Bailing out. bsel: 0, bus: pci.0 bsel: 0, bus: pci.0 bsel: 0, bus: pci.0 bsel: 0, bus: pci.0 Thanks ! -- Sander >> Also, Xen really should switch to fw cfg some day ... > Yeah, especially because nowadays "-M pc" works with Xen. It would be > nice if fw_cfg could be enabled even for Xen on all machines except the > legacy "-M xenfv". > Stefano, could you give it a shot now that you'll be soon done with 4.4? > Paolo >> hw/i386/pc_piix.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >> index a327d71..1acd2b2 100644 >> --- a/hw/i386/pc_piix.c >> +++ b/hw/i386/pc_piix.c >> @@ -793,6 +793,17 @@ static QEMUMachine xenfv_machine = { >> .max_cpus = HVM_MAX_VCPUS, >> .default_machine_opts = "accel=xen", >> .hot_add_cpu = pc_hot_add_cpu, >> + .compat_props = (GlobalProperty[]) { >> + /* xenfv has no fwcfg and so does not load acpi from QEMU. >> + * as such new acpi features don't work. >> + */ >> + { >> + .driver = "PIIX4_PM", >> + .property = "acpi-pci-hotplug-with-bridge-support", >> + .value = "off", >> + }, >> + { /* end of list */ } >> + }, >> }; >> #endif >> >>