From: "MaxF (Code Review)"
Date: Fri, 27 Dec 2024 18:34:57 +0000
In-Reply-To:
References:
Reply-To: max@...2606..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
lstipakov@...277...
Message-ID: <96b52a15287f6b337e5ade7ae34f8a231f848146-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="kHMTzWQiEwE="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add methods to
read/write packet ids for epoch data
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: flichtenheld , stipa , openvpn-devel
--kHMTzWQiEwE=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, stipa.
MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/open=
vpn/+/803?usp=3Demail )
Change subject: Add methods to read/write packet ids for epoch data
......................................................................
Patch Set 9:
(2 comments)
File src/openvpn/packet_id.h:
http://gerrit.openvpn.net/c/openvpn/+/803/comment/3292ddf7_01d6cdee :
PS8, Line 49: Maks
> Mask
Fixed while I had the tab open
http://gerrit.openvpn.net/c/openvpn/+/803/comment/6c8294d2_e55fc9fd :
PS8, Line 333: epcoh
> epoch
Fixed while I had the tab open
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bcd0560b67a07b5
Gerrit-Change-Number: 803
Gerrit-PatchSet: 9
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: MaxF
Gerrit-CC: openvpn-devel
Gerrit-CC: stipa
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: stipa
Gerrit-Comment-Date: Fri, 27 Dec 2024 18:34:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: MaxF
Gerrit-MessageType: comment
--kHMTzWQiEwE=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, stipa. <=
/p>
View C=
hange
2 comments:
Fixed while I had the tab open
To=
view, visit change 803. To unsubscribe, or for help writing mail filters, visit=
settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bc=
d0560b67a07b5
Gerrit-Change-Number: 803
Gerrit-PatchSet: 9
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: MaxF <max@...2606...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <=
/div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Fri, 27 Dec 2024 18:34:57=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: MaxF <max@...2606...&g=
t;
Gerrit-MessageType: comment
--kHMTzWQiEwE=--