Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=McrtQ8obU5Om5cXyFjqgKkVkgEBA+mbnsrN4F43Q2fs=; b=jzK6m5S0ncmUTayTpfPfajH1g/vkb6m6uIM5t+CYi3+GDEJ2E5MSJje4olEJucmKjK 6MTAAaWiSueQ7f9bQgO/0Y6kJqewl35WcT75d2xq4ay91THc24lEIJWdBJ1/K+Gn4zZu kq9UjT92OrKuu22umvEMcXClJqYV16mfe5NkgVa/KNWx5MKi3oumZfhRTOEpx4snyZaj lBhg7PhL0BiBIOABeMHdl4IaEfrokt3/72F/hNIkQVpb8oPD6vd2l3Ix1q6vjLito+RX Lb6Swc2ViJqzIOD/955ONw19MXOLO8UZXE8O5MmdA/vT+98p0bjgD8/UDvQSJSeEl/8V AElg== References: <20210106095136.224739-1-olteanv@gmail.com> <20210106095136.224739-3-olteanv@gmail.com> From: Florian Fainelli Message-ID: <96cdb139-fdcd-521f-4c19-f24a994afed5@gmail.com> Date: Wed, 6 Jan 2021 09:44:02 -0800 MIME-Version: 1.0 In-Reply-To: <20210106095136.224739-3-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v4 net-next 2/7] net: dsa: be louder when a non-legacy FDB operation fails List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Oltean , Andrew Lunn , Vivien Didelot , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, Roopa Prabhu , Nikolay Aleksandrov , "David S. Miller" Cc: Jiri Pirko , Alexandra Winter , Ido Schimmel , Russell King - ARM Linux admin , Marek Behun , DENG Qingfang , Claudiu Manoil , UNGLinuxDriver@microchip.com, Tobias Waldekranz On 1/6/21 1:51 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The dev_close() call was added in commit c9eb3e0f8701 ("net: dsa: Add > support for learning FDB through notification") "to indicate inconsistent > situation" when we could not delete an FDB entry from the port. > > bridge fdb del d8:58:d7:00:ca:6d dev swp0 self master > > It is a bit drastic and at the same time not helpful if the above fails > to only print with netdev_dbg log level, but on the other hand to bring > the interface down. > > So increase the verbosity of the error message, and drop dev_close(). > > Signed-off-by: Vladimir Oltean > Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian