From: "flichtenheld (Code Review)" Date: Tue, 12 Dec 2023 13:10:50 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <96e00bea720d40877e722ad6fd04b9ae9b3eb778-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="qqRy+LG1itM="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --qqRy+LG1itM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/471?usp=3Demail ) Change subject: Add test_ssl unit test and test export of PEM to file ...................................................................... Patch Set 2: Code-Review-1 (3 comments) File tests/unit_tests/openvpn/Makefile.am: http://gerrit.openvpn.net/c/openvpn/+/471/comment/0c7d5a64_4d9a9d5c : PS2, Line 86: $(top_srcdir)/src/openvpn/xkey_provider.c \ indent File tests/unit_tests/openvpn/mock_management.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/1c9c81df_b412d262 : PS2, Line 49: (void) man; inconsistent (void), used it in one function, but not the other File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/f87f0957_64554c69 : PS2, Line 47: /* Mock function to be allowed to include win32.c which is re= quired for You originally created win32-util.c for the purpose of UT (see commit 5a571= fb0f68ce6961cddfa495af2cedf3ee0e216). Maybe just move the win_get_tempdir t= o that? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Gerrit-Change-Number: 471 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Tue, 12 Dec 2023 13:10:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --qqRy+LG1itM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 2:Code-Review -1=

Vi= ew Change

3 comments:

  • File tests/unit_tests/openvpn/M= akefile.am:

  • File tests/unit_tests/openvpn/mock_management.c:

  • File tests/unit_tests/openvpn/test_ssl= .c:

    • Patch Set #2, L= ine 47: /* Mock functio= n to be allowed to include win32.c which is required for

      You originally created w= in32-util.c for the purpose of UT (see commit 5a571fb0f68ce6961cddfa495af2c= edf3ee0e216). Maybe just move the win_get_tempdir to that?

To view, visit change 471. To unsubscribe, or for help writing mail fi= lters, visit settings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c= 77ba0d6fa3381
Gerrit-Change-Number: 471
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Tue, 12 Dec 2023 13:10:50= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--qqRy+LG1itM=--